Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49703 )
(
50 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: cpu: Eliminate the (read|set)VecPredReg helpers from
ThreadContext.
......................................................................
cpu: Eliminate the (read|set)VecPredReg helpers from ThreadContext.
Change-Id: I9f220ba4f28d6a63e4f037388b0431dfe123a8a9
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49703
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Giacomo Travaglini <[email protected]>
---
M src/cpu/thread_context.cc
M src/cpu/thread_context.hh
2 files changed, 15 insertions(+), 21 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/thread_context.cc b/src/cpu/thread_context.cc
index aab475b..2c2e248 100644
--- a/src/cpu/thread_context.cc
+++ b/src/cpu/thread_context.cc
@@ -231,7 +231,7 @@
const size_t numPreds = regClasses.at(VecPredRegClass).numRegs();
std::vector<TheISA::VecPredRegContainer> vecPredRegs(numPreds);
for (int i = 0; i < numPreds; ++i) {
- vecPredRegs[i] = tc.readVecPredRegFlat(i);
+ tc.getRegFlat(RegId(VecPredRegClass, i), &vecPredRegs[i]);
}
SERIALIZE_CONTAINER(vecPredRegs);
@@ -278,7 +278,7 @@
std::vector<TheISA::VecPredRegContainer> vecPredRegs(numPreds);
UNSERIALIZE_CONTAINER(vecPredRegs);
for (int i = 0; i < numPreds; ++i) {
- tc.setVecPredRegFlat(i, vecPredRegs[i]);
+ tc.setRegFlat(RegId(VecPredRegClass, i), &vecPredRegs[i]);
}
const size_t numInts = regClasses.at(IntRegClass).numRegs();
diff --git a/src/cpu/thread_context.hh b/src/cpu/thread_context.hh
index cbbd11c..093d48c 100644
--- a/src/cpu/thread_context.hh
+++ b/src/cpu/thread_context.hh
@@ -374,25 +374,6 @@
setRegFlat(RegId(VecElemClass, idx), val);
}
- TheISA::VecPredRegContainer
- readVecPredRegFlat(RegIndex idx) const
- {
- TheISA::VecPredRegContainer val;
- getRegFlat(RegId(VecPredRegClass, idx), &val);
- return val;
- }
- TheISA::VecPredRegContainer&
- getWritableVecPredRegFlat(RegIndex idx)
- {
- return *(TheISA::VecPredRegContainer *)getWritableRegFlat(
- RegId(VecPredRegClass, idx));
- }
- void
- setVecPredRegFlat(RegIndex idx, const TheISA::VecPredRegContainer& val)
- {
- setRegFlat(RegId(VecPredRegClass, idx), &val);
- }
-
RegVal
readCCRegFlat(RegIndex idx) const
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49703
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9f220ba4f28d6a63e4f037388b0431dfe123a8a9
Gerrit-Change-Number: 49703
Gerrit-PatchSet: 52
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
