Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/55591 )
(
11 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: arch-x86: Straighten out the segment and selector for
real far jumps.
......................................................................
arch-x86: Straighten out the segment and selector for real far jumps.
These had been partially transposed in the microcode for this
instruction.
Change-Id: Ida31e74d5096c6b8cf77dc49b9a0f480c1358009
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55591
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py
1 file changed, 20 insertions(+), 4 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git
a/src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py
b/src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py
index b289f18..c747c96 100644
--- a/src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py
+++ b/src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py
@@ -153,12 +153,12 @@
lea t1, seg, sib, disp, dataSize=asz
ld t2, seg, [1, t0, t1], dsz
ld t1, seg, [1, t0, t1]
- zexti t3, t1, 15, dataSize=8
+ zexti t3, t2, 15, dataSize=8
slli t3, t3, 4, dataSize=8
- wrsel cs, t1, dataSize=2
+ wrsel cs, t2, dataSize=2
wrbase cs, t3, dataSize=8
- # Put t2 first so it isn't sign extended.
- wrip t2, t0
+ # Put t1 first so it isn't sign extended.
+ wrip t1, t0
};
def macroop JMP_FAR_REAL_P
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55591
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ida31e74d5096c6b8cf77dc49b9a0f480c1358009
Gerrit-Change-Number: 55591
Gerrit-PatchSet: 13
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bradford Beckmann <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
