Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49733 )
(
60 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: arch: Remove support for lists in def operands.
......................................................................
arch: Remove support for lists in def operands.
Change-Id: I4e9f4e0ff215a60443d408c0b8d53f1ff450a784
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49733
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
---
M src/arch/isa_parser/isa_parser.py
1 file changed, 17 insertions(+), 13 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/isa_parser/isa_parser.py
b/src/arch/isa_parser/isa_parser.py
index fdab1f7..5735f97 100755
--- a/src/arch/isa_parser/isa_parser.py
+++ b/src/arch/isa_parser/isa_parser.py
@@ -1456,19 +1456,10 @@
def buildOperandNameMap(self, user_dict, lineno):
operand_name = {}
- for op_name, val in user_dict.items():
- if isinstance(val, OperandDesc):
- op_desc = val
- base_cls_name = op_desc.attrs['base_cls_name']
- else:
- assert(isinstance(val, (list, tuple)))
- base_cls_name = val[0]
- # Check if extra attributes have been specified.
- if len(val) > 9:
- error(lineno,
- 'error: too many attributes for operand "%s"' %
- base_cls_name)
- op_desc = OperandDesc(*val)
+ for op_name, op_desc in user_dict.items():
+ assert(isinstance(op_desc, OperandDesc))
+
+ base_cls_name = op_desc.attrs['base_cls_name']
op_desc.setName(op_name)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49733
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4e9f4e0ff215a60443d408c0b8d53f1ff450a784
Gerrit-Change-Number: 49733
Gerrit-PatchSet: 62
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
