Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49736 )
(
62 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: arch: Disable unused read/write code overrides in the ISA
parser.
......................................................................
arch: Disable unused read/write code overrides in the ISA parser.
Some operand types had read/write code overrides, I think largely by
pattern matching other operand types, and not because that code was
actually expected to be used or to work. Instead, we should just assert
that that code isn't used and remove the implementation. This method of
affecting reading and writing code is going away anyway, and if this is
needed in the future it can be replaced in the new system.
Change-Id: Idae886153aa343570109069cbe54e2c1699a34e5
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49736
Reviewed-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Maintainer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/isa_parser/operand_types.py
1 file changed, 22 insertions(+), 6 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/isa_parser/operand_types.py
b/src/arch/isa_parser/operand_types.py
index 27e0ac7..342bd6f 100755
--- a/src/arch/isa_parser/operand_types.py
+++ b/src/arch/isa_parser/operand_types.py
@@ -341,9 +341,7 @@
return c_read
def makeReadW(self, predWrite):
- func = 'getWritableRegOperand'
- if self.read_code != None:
- return self.buildReadCode(predWrite, func)
+ assert(self.read_code == None)
if predWrite:
rindex = '_destIndex++'
@@ -454,9 +452,7 @@
return c_read
def makeReadW(self, predWrite):
- func = 'getWritableRegOperand'
- if self.read_code != None:
- return self.buildReadCode(predWrite, 'getWritableRegOperand')
+ assert(self.read_code == None)
if predWrite:
rindex = '_destIndex++'
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49736
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Idae886153aa343570109069cbe54e2c1699a34e5
Gerrit-Change-Number: 49736
Gerrit-PatchSet: 64
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
