Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/56324 )
(
9 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: arch-x86: Implement IntCSCheck for legacy mode.
......................................................................
arch-x86: Implement IntCSCheck for legacy mode.
Change-Id: Ic011b796cbccec030ffcb52ee4033ceaee6bf8fa
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/56324
Reviewed-by: Matt Sinclair <mattdsincl...@gmail.com>
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/x86/isa/microops/regop.isa
1 file changed, 16 insertions(+), 5 deletions(-)
Approvals:
Matt Sinclair: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/x86/isa/microops/regop.isa
b/src/arch/x86/isa/microops/regop.isa
index 556a02c..97ab143 100644
--- a/src/arch/x86/isa/microops/regop.isa
+++ b/src/arch/x86/isa/microops/regop.isa
@@ -1533,14 +1533,12 @@
break;
}
case SegIntCSCheck:
- if (m5reg.mode == LongMode) {
+ if (desc.type.codeOrData != 1) {
+ fault = std::make_shared<GeneralProtection>(selector);
+ } else if (m5reg.mode == LongMode) {
if (desc.l != 1 || desc.d != 0) {
fault =
std::make_shared<GeneralProtection>(selector);
}
- } else {
- fault = std::make_shared<GenericISA::M5PanicFault>(
- "Interrupt CS "
- "checks not implemented in legacy mode.\\n");
}
break;
case SegTRCheck:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/56324
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic011b796cbccec030ffcb52ee4033ceaee6bf8fa
Gerrit-Change-Number: 56324
Gerrit-PatchSet: 11
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
