Matt Sinclair has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/57535 )
Change subject: tests,configs,mem-ruby: Handle num DMAs in GPU Ruby tester
......................................................................
tests,configs,mem-ruby: Handle num DMAs in GPU Ruby tester
Currently the GPU Ruby tester does not support requests returned
as aliased. To get around this, the GPU Ruby tester needs
numDMAs to be 0. To enable this, change the default value to allow
us to identify when a user wants more DMAs.
Change-Id: I0a31f66c831f0379544c15bd7364f185e1edb1b2
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/57535
Maintainer: Matt Sinclair <mattdsincl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Matthew Poremba <matthew.pore...@amd.com>
---
M configs/example/ruby_gpu_random_test.py
1 file changed, 30 insertions(+), 7 deletions(-)
Approvals:
Matthew Poremba: Looks good to me, approved
Matt Sinclair: Looks good to me, approved
kokoro: Regressions pass
diff --git a/configs/example/ruby_gpu_random_test.py
b/configs/example/ruby_gpu_random_test.py
index 0763454..029a97d 100644
--- a/configs/example/ruby_gpu_random_test.py
+++ b/configs/example/ruby_gpu_random_test.py
@@ -79,7 +79,7 @@
help="Random seed number. Default value (i.e., 0)
means \
using runtime-specific value")
parser.add_argument("--log-file", type=str, default="gpu-ruby-test.log")
-parser.add_argument("--num-dmas", type=int, default=0,
+parser.add_argument("--num-dmas", type=int, default=None,
help="The number of DMA engines to use in tester
config.")
args = parser.parse_args()
@@ -108,7 +108,7 @@
args.wf_size = 1
args.wavefronts_per_cu = 1
args.num_cpus = 1
- args.num_dmas = 1
+ n_DMAs = 1
args.cu_per_sqc = 1
args.cu_per_scalar_cache = 1
args.num_compute_units = 1
@@ -117,7 +117,7 @@
args.wf_size = 16
args.wavefronts_per_cu = 4
args.num_cpus = 4
- args.num_dmas = 2
+ n_DMAs = 2
args.cu_per_sqc = 4
args.cu_per_scalar_cache = 4
args.num_compute_units = 4
@@ -126,11 +126,19 @@
args.wf_size = 32
args.wavefronts_per_cu = 4
args.num_cpus = 4
- args.num_dmas = 4
+ n_DMAs = 4
args.cu_per_sqc = 4
args.cu_per_scalar_cache = 4
args.num_compute_units = 8
+# Number of DMA engines
+if not(args.num_dmas is None):
+ n_DMAs = args.num_dmas
+ # currently the tester does not support requests returned as
+ # aliased, thus we need num_dmas to be 0 for it
+ if not(args.num_dmas == 0):
+ print("WARNING: num_dmas != 0 not supported with VIPER")
+
#
# Set address range - 2 options
# level 0: small
@@ -173,9 +181,6 @@
# For now we're testing only GPU protocol, so we force num_cpus to be 0
args.num_cpus = 0
-# Number of DMA engines
-n_DMAs = args.num_dmas
-
# Number of CUs
n_CUs = args.num_compute_units
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/57535
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0a31f66c831f0379544c15bd7364f185e1edb1b2
Gerrit-Change-Number: 57535
Gerrit-PatchSet: 5
Gerrit-Owner: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-CC: Alexandru Duțu <alexandru.d...@amd.com>
Gerrit-CC: Bradford Beckmann <bradford.beckm...@gmail.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
