Bobby Bruce has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/58149 )
Change subject: dev-amdgpu: Remove unused variables in src/dev/amdgpu
......................................................................
dev-amdgpu: Remove unused variables in src/dev/amdgpu
These were causing errors to be thrown when compiling in clang-12.
Change-Id: I8bd2d7e7e1d4423a54766ed906c864bb91e884f0
---
M src/dev/amdgpu/amdgpu_device.hh
M src/dev/amdgpu/system_hub.cc
M src/dev/amdgpu/system_hub.hh
3 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/dev/amdgpu/amdgpu_device.hh
b/src/dev/amdgpu/amdgpu_device.hh
index 09c13c9..6697d82 100644
--- a/src/dev/amdgpu/amdgpu_device.hh
+++ b/src/dev/amdgpu/amdgpu_device.hh
@@ -121,16 +121,6 @@
bool checkpoint_before_mmios;
int init_interrupt_count;
- // GART aperture. This is the initial 1-level privledged page table
that
- // resides in framebuffer memory.
- uint32_t gartBase = 0x0;
- uint32_t gartSize = 0x0;
-
- // MMHUB aperture. These addresses are set by the GPU. For now we wait
- // until the driver reads them before setting them.
- uint64_t mmhubBase = 0x0;
- uint64_t mmhubTop = 0x0;
-
// VMIDs data structures
// map of pasids to vmids
std::unordered_map<uint16_t, uint16_t> idMap;
diff --git a/src/dev/amdgpu/system_hub.cc b/src/dev/amdgpu/system_hub.cc
index b55cc52..90dcb7f 100644
--- a/src/dev/amdgpu/system_hub.cc
+++ b/src/dev/amdgpu/system_hub.cc
@@ -39,7 +39,7 @@
void
AMDGPUSystemHub::sendRequest(PacketPtr pkt, Event *callback)
{
- ResponseEvent *dmaRespEvent = new ResponseEvent(pkt, callback);
+ ResponseEvent *dmaRespEvent = new ResponseEvent(callback);
Tick delay = 0;
// Assuming read XOR write (i.e., not an atomic).
@@ -59,8 +59,8 @@
{
}
-AMDGPUSystemHub::ResponseEvent::ResponseEvent(PacketPtr pkt, Event
*_callback)
- : reqPkt(pkt), callback(_callback)
+AMDGPUSystemHub::ResponseEvent::ResponseEvent(Event *_callback)
+ : callback(_callback)
{
// Delete this event after process is called
setFlags(Event::AutoDelete);
diff --git a/src/dev/amdgpu/system_hub.hh b/src/dev/amdgpu/system_hub.hh
index 2de627f..0b48c3b 100644
--- a/src/dev/amdgpu/system_hub.hh
+++ b/src/dev/amdgpu/system_hub.hh
@@ -66,11 +66,10 @@
class ResponseEvent : public Event
{
- PacketPtr reqPkt;
Event *callback;
public:
- ResponseEvent(PacketPtr pkt, Event *_callback);
+ ResponseEvent(Event *_callback);
void process();
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/58149
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I8bd2d7e7e1d4423a54766ed906c864bb91e884f0
Gerrit-Change-Number: 58149
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s