Jason Lowe-Power has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/64015?usp=email )
Change subject: stdlib: Allow cache_hierarchy to be optional
......................................................................
stdlib: Allow cache_hierarchy to be optional
This changeset makes the cache_hierarchy optional on the board. This
will allow us to enable the TestBoard to have memory directly connected
to the traffic generator.
Change-Id: I62d310e74c43724ea38e3b71a4d91d9e06d6e855
Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/64015
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Bobby Bruce <bbr...@ucdavis.edu>
Maintainer: Bobby Bruce <bbr...@ucdavis.edu>
---
M src/python/gem5/components/boards/abstract_board.py
1 file changed, 30 insertions(+), 7 deletions(-)
Approvals:
Bobby Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/python/gem5/components/boards/abstract_board.py
b/src/python/gem5/components/boards/abstract_board.py
index e480190..1fe7902 100644
--- a/src/python/gem5/components/boards/abstract_board.py
+++ b/src/python/gem5/components/boards/abstract_board.py
@@ -39,7 +39,7 @@
VoltageDomain,
)
-from typing import List
+from typing import List, Optional
class AbstractBoard:
@@ -68,13 +68,15 @@
clk_freq: str,
processor: "AbstractProcessor",
memory: "AbstractMemorySystem",
- cache_hierarchy: "AbstractCacheHierarchy",
+ cache_hierarchy: Optional["AbstractCacheHierarchy"],
) -> None:
"""
:param clk_freq: The clock frequency for this board.
:param processor: The processor for this board.
:param memory: The memory for this board.
- :param cache_hierarchy: The Cachie Hierarchy for this board.
+ :param cache_hierarchy: The Cache Hierarchy for this board.
+ In some boards caches can be optional. If
so,
+ that board must override `_connect_things`.
"""
if not isinstance(self, System):
@@ -88,7 +90,9 @@
# Set the processor, memory, and cache hierarchy.
self.processor = processor
self.memory = memory
- self.cache_hierarchy = cache_hierarchy
+ self._cache_hierarchy = cache_hierarchy
+ if cache_hierarchy is not None:
+ self.cache_hierarchy = cache_hierarchy
# This variable determines whether the board is to be executed in
# full-system or syscall-emulation mode. This is set when the
workload
@@ -119,12 +123,12 @@
"""
return self.memory
- def get_cache_hierarchy(self) -> "AbstractCacheHierarchy":
+ def get_cache_hierarchy(self) -> Optional["AbstractCacheHierarchy"]:
"""Get the cache hierarchy connected to the board.
:returns: The cache hierarchy.
"""
- return self.cache_hierarchy
+ return self._cache_hierarchy
def get_cache_line_size(self) -> int:
"""Get the size of the cache line.
@@ -329,7 +333,8 @@
self.get_memory().incorporate_memory(self)
# Incorporate the cache hierarchy for the motherboard.
- self.get_cache_hierarchy().incorporate_cache(self)
+ if self.get_cache_hierarchy():
+ self.get_cache_hierarchy().incorporate_cache(self)
# Incorporate the processor into the motherboard.
self.get_processor().incorporate_processor(self)
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/64015?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I62d310e74c43724ea38e3b71a4d91d9e06d6e855
Gerrit-Change-Number: 64015
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
