Jason Yu has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/64471?usp=email )
Change subject: sim,sim-se: Fixes the bug of missing "/" in path resolution
......................................................................
sim,sim-se: Fixes the bug of missing "/" in path resolution
The syscall emulation did not correctly handle the scenario where the
base path does not end with "/". The "/" should be appended first
before the file name is appended. This commit fixes this bug.
Change-Id: I9a9b38d1885e46b2a0e42018fd7d68010c70133c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/64471
Maintainer: Bobby Bruce <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby Bruce <[email protected]>
---
M src/sim/process.cc
1 file changed, 18 insertions(+), 1 deletion(-)
Approvals:
Bobby Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/process.cc b/src/sim/process.cc
index 97130bd..a348b45 100644
--- a/src/sim/process.cc
+++ b/src/sim/process.cc
@@ -520,7 +520,7 @@
}
// Add a trailing '/' if the current working directory did not have
one.
- normalize(path_base);
+ path_base = normalize(path_base);
// Append the filename onto the current working path.
auto absolute_path = path_base + filename;
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/64471?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9a9b38d1885e46b2a0e42018fd7d68010c70133c
Gerrit-Change-Number: 64471
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Yu <[email protected]>
Gerrit-Reviewer: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Yu <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
