Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/65195?usp=email )
Change subject: tests: Remove ARM compilation requirement for quick/Kokoro
......................................................................
tests: Remove ARM compilation requirement for quick/Kokoro
The ARM Boot Tests required the compilation of ARM/gem5.opt to run a
quick test that the CHI protocol was functioning correctly with ARM and
the ArmBoard. This test has been removed and the test refactored
slightly to use the ALL/gem5.opt.
The CHI protocol is already tested nightly.
Change-Id: Ibe406348caefa2493860036eb89a20681478ea66
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65195
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby Bruce <[email protected]>
Maintainer: Bobby Bruce <[email protected]>
---
M tests/gem5/arm-boot-tests/test_linux_boot.py
1 file changed, 21 insertions(+), 21 deletions(-)
Approvals:
Bobby Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/tests/gem5/arm-boot-tests/test_linux_boot.py
b/tests/gem5/arm-boot-tests/test_linux_boot.py
index 6115bb2..3641256 100644
--- a/tests/gem5/arm-boot-tests/test_linux_boot.py
+++ b/tests/gem5/arm-boot-tests/test_linux_boot.py
@@ -77,16 +77,12 @@
if mem_system == "chi":
protocol_to_use = "CHI"
- isa_to_use = constants.arm_tag
elif mem_system == "mesi_two_level":
protocol_to_use = None
- isa_to_use = constants.all_compiled_tag
elif mem_system == "mi_example":
protocol_to_use = "MI_example"
- isa_to_use = constants.arm_tag
else:
protocol_to_use = None
- isa_to_use = constants.all_compiled_tag
gem5_verify_config(
name=name,
@@ -100,7 +96,7 @@
"arm_boot_exit_run.py",
),
config_args=config_args,
- valid_isas=(isa_to_use,),
+ valid_isas=(constants.all_compiled,),
valid_hosts=constants.supported_hosts,
length=length,
protocol=protocol_to_use,
@@ -154,14 +150,6 @@
to_tick=10000000000,
)
-test_boot(
- cpu="timing",
- num_cpus=2,
- mem_system="chi",
- memory_class="DualChannelDDR4_2400",
- length=constants.quick_tag,
- to_tick=10000000000,
-)
test_boot(
cpu="timing",
@@ -172,14 +160,6 @@
to_tick=10000000000,
)
-test_boot(
- cpu="timing",
- num_cpus=2,
- mem_system="mi_example",
- memory_class="DualChannelDDR4_2400",
- length=constants.quick_tag,
- to_tick=10000000000,
-)
#### The long (nightly) tests ####
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/65195?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibe406348caefa2493860036eb89a20681478ea66
Gerrit-Change-Number: 65195
Gerrit-PatchSet: 2
Gerrit-Owner: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Bobby Bruce <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
