Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/64773?usp=email )
Change subject: stdlib: Fixing erroneous typing in Simulator __init__
......................................................................
stdlib: Fixing erroneous typing in Simulator __init__
The key in the `on_exit_event` dictionary can only be an ExitEvent. The
typing information here suggested a string could be passed. This is not
the case. This patch fixes the issue.
Change-Id: Iaa4b66417c15e31f6aafe9e550a7552461a15be1
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/64773
Maintainer: Bobby Bruce <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby Bruce <[email protected]>
---
M src/python/gem5/simulate/simulator.py
1 file changed, 18 insertions(+), 1 deletion(-)
Approvals:
Bobby Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/python/gem5/simulate/simulator.py
b/src/python/gem5/simulate/simulator.py
index b32e54a..1d0d3ec 100644
--- a/src/python/gem5/simulate/simulator.py
+++ b/src/python/gem5/simulate/simulator.py
@@ -87,7 +87,7 @@
board: AbstractBoard,
full_system: Optional[bool] = None,
on_exit_event: Optional[
- Dict[Union[str, ExitEvent], Generator[Optional[bool], None,
None]]
+ Dict[ExitEvent, Generator[Optional[bool], None, None]]
] = None,
expected_execution_order: Optional[List[ExitEvent]] = None,
checkpoint_path: Optional[Path] = None,
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/64773?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iaa4b66417c15e31f6aafe9e550a7552461a15be1
Gerrit-Change-Number: 64773
Gerrit-PatchSet: 14
Gerrit-Owner: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Melissa Jost <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
