Bobby Bruce has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/65732?usp=email )
Change subject: arch-arm: Revert 'Setup TC/ISA at construction time..'
......................................................................
arch-arm: Revert 'Setup TC/ISA at construction time..'
Reverts:
dd2f1fb2f8520849f10fc25fc5eab5beaa90a7d4
https://gem5-review.googlesource.com/c/public/gem5/+/65174
and
47bd56ee71ba1d684138365e7123aa779989ba1d
https://gem5-review.googlesource.com/c/public/gem5/+/65291
The 47bd56ee change resulted in the
`SuiteUID:tests/gem5/fs/linux/arm/test.py:realview-switcheroo-noncaching-timing-ALL-x86_64-opt`
nightly test stalling. This behavior can be reproduced with:
```
./build/ALL/gem5.opt tests/gem5/fs/linux/arm/run.py
tests/gem5/configs/realview-switcheroo-noncaching-timing.py
tests/gem5/resources/arm “$(pwd)”
```
The subsequent change, dd2f1fb2, must be reverted for this change to be
reverted.
Change-Id: I6fed74f33d013f321b93cf1a73eee404cb87ce18
---
M src/arch/arm/isa.cc
M src/dev/arm/gic_v3.cc
M src/dev/arm/gic_v3_cpu_interface.cc
M src/dev/arm/gic_v3_cpu_interface.hh
4 files changed, 58 insertions(+), 20 deletions(-)
diff --git a/src/arch/arm/isa.cc b/src/arch/arm/isa.cc
index fd19f72..a30fd94 100644
--- a/src/arch/arm/isa.cc
+++ b/src/arch/arm/isa.cc
@@ -523,6 +523,16 @@
return;
selfDebug->init(tc);
+
+ Gicv3 *gicv3 = dynamic_cast<Gicv3 *>(system->getGIC());
+ if (!gicv3)
+ return;
+
+ if (!gicv3CpuInterface)
+ gicv3CpuInterface.reset(gicv3->getCPUInterface(tc->contextId()));
+
+ gicv3CpuInterface->setISA(this);
+ gicv3CpuInterface->setThreadContext(tc);
}
void
@@ -1998,15 +2008,7 @@
BaseISADevice &
ISA::getGICv3CPUInterface()
{
- if (gicv3CpuInterface)
- return *gicv3CpuInterface.get();
-
- assert(system);
- Gicv3 *gicv3 = dynamic_cast<Gicv3 *>(system->getGIC());
- panic_if(!gicv3, "The system does not have a GICv3 irq controller\n");
-
- gicv3CpuInterface.reset(gicv3->getCPUInterface(tc->contextId()));
-
+ panic_if(!gicv3CpuInterface, "GICV3 cpu interface is not registered!");
return *gicv3CpuInterface.get();
}
diff --git a/src/dev/arm/gic_v3.cc b/src/dev/arm/gic_v3.cc
index e14d1f2..dde3818 100644
--- a/src/dev/arm/gic_v3.cc
+++ b/src/dev/arm/gic_v3.cc
@@ -147,7 +147,7 @@
for (int i = 0; i < threads; i++) {
redistributors[i] = new Gicv3Redistributor(this, i);
- cpuInterfaces[i] = new Gicv3CPUInterface(this, sys->threads[i]);
+ cpuInterfaces[i] = new Gicv3CPUInterface(this, i);
}
distRange = RangeSize(params().dist_addr,
diff --git a/src/dev/arm/gic_v3_cpu_interface.cc
b/src/dev/arm/gic_v3_cpu_interface.cc
index a11dd9b..0e1dbaa 100644
--- a/src/dev/arm/gic_v3_cpu_interface.cc
+++ b/src/dev/arm/gic_v3_cpu_interface.cc
@@ -55,19 +55,15 @@
const uint8_t Gicv3CPUInterface::GIC_MIN_BPR;
const uint8_t Gicv3CPUInterface::GIC_MIN_BPR_NS;
-Gicv3CPUInterface::Gicv3CPUInterface(Gicv3 * gic, ThreadContext *_tc)
+Gicv3CPUInterface::Gicv3CPUInterface(Gicv3 * gic, uint32_t cpu_id)
: BaseISADevice(),
gic(gic),
redistributor(nullptr),
distributor(nullptr),
- tc(_tc),
- maintenanceInterrupt(gic->params().maint_int->get(tc)),
- cpuId(tc->contextId())
+ cpuId(cpu_id)
{
hppi.prio = 0xff;
hppi.intid = Gicv3::INTID_SPURIOUS;
-
- setISA(static_cast<ISA*>(tc->getIsaPtr()));
}
void
@@ -84,6 +80,15 @@
hppi.prio = 0xff;
}
+void
+Gicv3CPUInterface::setThreadContext(ThreadContext *_tc)
+{
+ tc = _tc;
+ maintenanceInterrupt = gic->params().maint_int->get(tc);
+ fatal_if(maintenanceInterrupt->num() >=
redistributor->irqPending.size(),
+ "Invalid maintenance interrupt number\n");
+}
+
bool
Gicv3CPUInterface::getHCREL2FMO() const
{
diff --git a/src/dev/arm/gic_v3_cpu_interface.hh
b/src/dev/arm/gic_v3_cpu_interface.hh
index c39fab7..e860373 100644
--- a/src/dev/arm/gic_v3_cpu_interface.hh
+++ b/src/dev/arm/gic_v3_cpu_interface.hh
@@ -68,11 +68,11 @@
Gicv3 * gic;
Gicv3Redistributor * redistributor;
Gicv3Distributor * distributor;
-
- ThreadContext *tc;
- ArmInterruptPin *maintenanceInterrupt;
uint32_t cpuId;
+ ArmInterruptPin *maintenanceInterrupt;
+ ThreadContext *tc;
+
BitUnion64(ICC_CTLR_EL1)
Bitfield<63, 20> res0_3;
Bitfield<19> ExtRange;
@@ -359,7 +359,7 @@
void setBankedMiscReg(ArmISA::MiscRegIndex misc_reg, RegVal val) const;
public:
- Gicv3CPUInterface(Gicv3 * gic, ThreadContext *tc);
+ Gicv3CPUInterface(Gicv3 * gic, uint32_t cpu_id);
void init();
@@ -369,6 +369,7 @@
public: // BaseISADevice
RegVal readMiscReg(int misc_reg) override;
void setMiscReg(int misc_reg, RegVal val) override;
+ void setThreadContext(ThreadContext *tc) override;
};
} // namespace gem5
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/65732?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I6fed74f33d013f321b93cf1a73eee404cb87ce18
Gerrit-Change-Number: 65732
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
