Attention is currently required from: Jason Lowe-Power.
Hello kokoro, Jason Lowe-Power,
I'd like you to do a code review.
Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/65976?usp=email
to review the following change.
Change subject: configs: Add missing `_pre_instantiate` call
in "run_lupv.py"
......................................................................
configs: Add missing `_pre_instantiate` call in "run_lupv.py"
As of this change:
https://gem5-review.googlesource.com/c/public/gem5/+/65051, the
`_pre_instantiate` function must be called prior to `m5.instantiate`
when using the stdlib without the Simulator module.
Change-Id: Id5cec3b643d556b0f742719596abb53533b84cbd
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65871
Reviewed-by: Bobby Bruce <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Bobby Bruce <[email protected]>
---
M configs/example/lupv/run_lupv.py
1 file changed, 20 insertions(+), 0 deletions(-)
diff --git a/configs/example/lupv/run_lupv.py
b/configs/example/lupv/run_lupv.py
index f472f53..0056cf8 100644
--- a/configs/example/lupv/run_lupv.py
+++ b/configs/example/lupv/run_lupv.py
@@ -107,6 +107,7 @@
print("Running with ISA: " + processor.get_isa().name)
print()
root = Root(full_system=True, system=board)
+board._pre_instantiate()
m5.instantiate()
print("Beginning simulation!")
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/65976?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: release-staging-v22-1
Gerrit-Change-Id: Id5cec3b643d556b0f742719596abb53533b84cbd
Gerrit-Change-Number: 65976
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-Attention: Jason Lowe-Power <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
