Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/66152?usp=email )
Change subject: sim: Add missing virtual destructor to GlobalSyncEvent
......................................................................
sim: Add missing virtual destructor to GlobalSyncEvent
This missing destructor in GlobalSyncEvent was causing a compilation
error in gcc-12, thus causing the compiler-tests to fail:
https://jenkins.gem5.org/job/compiler-checks/436/
In addition a destructor was added to BaseGlobalEventTemplate. This does
not directly fix the aforementioned bug provides some additional
security.
Change-Id: Iab86d3f6d55064ba3b6a8a7cb01fb14533cce4b9
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66152
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
Maintainer: Bobby Bruce <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
---
M src/sim/global_event.hh
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Bobby Bruce: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/global_event.hh b/src/sim/global_event.hh
index 05ae6ca..3633204 100644
--- a/src/sim/global_event.hh
+++ b/src/sim/global_event.hh
@@ -162,6 +162,8 @@
for (int i = 0; i < numMainEventQueues; ++i)
barrierEvent[i] = new typename Derived::BarrierEvent(this, p,
f);
}
+
+ virtual ~BaseGlobalEventTemplate(){}
};
@@ -229,6 +231,8 @@
schedule(when);
}
+ virtual ~GlobalSyncEvent (){}
+
void process();
const char *description() const;
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/66152?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iab86d3f6d55064ba3b6a8a7cb01fb14533cce4b9
Gerrit-Change-Number: 66152
Gerrit-PatchSet: 4
Gerrit-Owner: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
