Hoa Nguyen has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/65571?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: stdlib: Clean up Ruby cache directory
......................................................................
stdlib: Clean up Ruby cache directory
- Fix typos.
- Fix type inconsistencies.
Change-Id: I98d82ec7e62130abb09295c5ec6cde86b1f7fa27
Signed-off-by: Hoa Nguyen <hoangu...@ucdavis.edu>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65571
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M
src/python/gem5/components/cachehierarchies/abstract_two_level_cache_hierarchy.py
M
src/python/gem5/components/cachehierarchies/ruby/caches/mesi_two_level/l2_cache.py
2 files changed, 20 insertions(+), 5 deletions(-)
Approvals:
kokoro: Regressions pass
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
diff --git
a/src/python/gem5/components/cachehierarchies/abstract_two_level_cache_hierarchy.py
b/src/python/gem5/components/cachehierarchies/abstract_two_level_cache_hierarchy.py
index 17cae4a..d6a035f 100644
---
a/src/python/gem5/components/cachehierarchies/abstract_two_level_cache_hierarchy.py
+++
b/src/python/gem5/components/cachehierarchies/abstract_two_level_cache_hierarchy.py
@@ -24,8 +24,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-# from .abstract_cache_hierarchy import AbstractCacheHierarchy
-
class AbstractTwoLevelCacheHierarchy:
"""
@@ -51,9 +49,9 @@
:type l1i_assoc: int
- :param l1dsize: The size of the LL1 Data cache (e.g. "32kB").
+ :param l1d_size: The size of the L1 Data cache (e.g. "32kB").
- :type l1dsize: str
+ :type l1d_size: str
:param l1d_assoc:
diff --git
a/src/python/gem5/components/cachehierarchies/ruby/caches/mesi_two_level/l2_cache.py
b/src/python/gem5/components/cachehierarchies/ruby/caches/mesi_two_level/l2_cache.py
index 56cb5b2..81ef4db 100644
---
a/src/python/gem5/components/cachehierarchies/ruby/caches/mesi_two_level/l2_cache.py
+++
b/src/python/gem5/components/cachehierarchies/ruby/caches/mesi_two_level/l2_cache.py
@@ -45,7 +45,7 @@
start_index_bit=self.getIndexBit(num_l2Caches),
)
- self.transitions_per_cycle = "4"
+ self.transitions_per_cycle = 4
def getIndexBit(self, num_l2caches):
l2_bits = int(math.log(num_l2caches, 2))
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/65571?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I98d82ec7e62130abb09295c5ec6cde86b1f7fa27
Gerrit-Change-Number: 65571
Gerrit-PatchSet: 4
Gerrit-Owner: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-Reviewer: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Hoa Nguyen <hoangu...@ucdavis.edu>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
