Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/66371?usp=email )
Change subject: util-gem5art: Fix incorrect type of size in `createArtifact`
......................................................................
util-gem5art: Fix incorrect type of size in `createArtifact`
The typing here was `int` but had a default value of `None`. The correct
type is therefore `Optional[int]`.
Change-Id: Ibaf63151196b15f68e643fa5c1b290439d6618c8
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66371
Maintainer: Bobby Bruce <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby Bruce <[email protected]>
---
M util/gem5art/artifact/gem5art/artifact/artifact.py
1 file changed, 17 insertions(+), 1 deletion(-)
Approvals:
Bobby Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/util/gem5art/artifact/gem5art/artifact/artifact.py
b/util/gem5art/artifact/gem5art/artifact/artifact.py
index 91ffc64..46664e8 100644
--- a/util/gem5art/artifact/gem5art/artifact/artifact.py
+++ b/util/gem5art/artifact/gem5art/artifact/artifact.py
@@ -158,7 +158,7 @@
documentation: str,
inputs: List["Artifact"] = [],
architecture: str = "",
- size: int = None,
+ size: Optional[int] = None,
is_zipped: bool = False,
md5sum: str = "",
url: str = "",
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/66371?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: release-staging-v22-1
Gerrit-Change-Id: Ibaf63151196b15f68e643fa5c1b290439d6618c8
Gerrit-Change-Number: 66371
Gerrit-PatchSet: 3
Gerrit-Owner: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
