Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/66512?usp=email )
Change subject: configs: Fix x86-gapbs-benchmarks.py example
......................................................................
configs: Fix x86-gapbs-benchmarks.py example
With https://gem5-review.googlesource.com/c/public/gem5/+/64791 we
updated the configs/example/gem5_library to utilize the `m5.simulate`
module. The GAPBS benchmark example uses the "WORKBEGIN" and "WORKEND"
exit events to specify the ROI. The patch incorrectly assumed an "EXIT"
exit event were used.
As such, the
"test-gem5-library-example-x86-gapbs-benchmarks-ALL-x86_64-opt-MESI_Two_Level"
test was not properly running, causing the Nightly test to fail:
https://jenkins.gem5.org/job/nightly/444. This patch fixes this error.
Change-Id: I207fe3563c8d9c59bcb79428fe62d2d2bbccd013
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/66512
Maintainer: Bobby Bruce <bbr...@ucdavis.edu>
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
---
M configs/example/gem5_library/x86-gapbs-benchmarks.py
1 file changed, 30 insertions(+), 2 deletions(-)
Approvals:
kokoro: Regressions pass
Bobby Bruce: Looks good to me, approved
Jason Lowe-Power: Looks good to me, approved
diff --git a/configs/example/gem5_library/x86-gapbs-benchmarks.py
b/configs/example/gem5_library/x86-gapbs-benchmarks.py
index 638d34b..6ab3747 100644
--- a/configs/example/gem5_library/x86-gapbs-benchmarks.py
+++ b/configs/example/gem5_library/x86-gapbs-benchmarks.py
@@ -211,7 +211,7 @@
)
-def handle_exit():
+def handle_workbegin():
print("Done booting Linux")
print("Resetting stats at the start of ROI!")
m5.stats.reset()
@@ -219,6 +219,9 @@
start_tick = m5.curTick()
processor.switch()
yield False # E.g., continue the simulation.
+
+
+def handle_workend():
print("Dump stats at the end of the ROI!")
m5.stats.dump()
yield True # Stop the simulation. We're done.
@@ -227,7 +230,8 @@
simulator = Simulator(
board=board,
on_exit_event={
- ExitEvent.EXIT: handle_exit(),
+ ExitEvent.WORKBEGIN: handle_workbegin(),
+ ExitEvent.WORKEND: handle_workend(),
},
)
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/66512?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I207fe3563c8d9c59bcb79428fe62d2d2bbccd013
Gerrit-Change-Number: 66512
Gerrit-PatchSet: 2
Gerrit-Owner: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
