Nathanael Premillieu has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/67473?usp=email )
Change subject: mem-cache: schedule already ready pf next cycle
......................................................................
mem-cache: schedule already ready pf next cycle
Fix a bug where a ready prefetch request was not
sent directly because the schedMemSideSendEvent
was not called with the right time.
This fix mimics what is done in recvTimingResp.
Change-Id: Ib11f8003ca1b006d976c8cc8ea541434b8902beb
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/67473
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby Bruce <[email protected]>
---
M src/mem/cache/base.cc
1 file changed, 21 insertions(+), 1 deletion(-)
Approvals:
Bobby Bruce: Looks good to me, approved
kokoro: Regressions pass
Jason Lowe-Power: Looks good to me, but someone else must approve; Looks
good to me, approved
diff --git a/src/mem/cache/base.cc b/src/mem/cache/base.cc
index cf6c9fe..639d026 100644
--- a/src/mem/cache/base.cc
+++ b/src/mem/cache/base.cc
@@ -464,7 +464,8 @@
if (prefetcher) {
// track time of availability of next prefetch, if any
- Tick next_pf_time = prefetcher->nextPrefetchReadyTime();
+ Tick next_pf_time = std::max(
+ prefetcher->nextPrefetchReadyTime(),
clockEdge());
if (next_pf_time != MaxTick) {
schedMemSideSendEvent(next_pf_time);
}
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/67473?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib11f8003ca1b006d976c8cc8ea541434b8902beb
Gerrit-Change-Number: 67473
Gerrit-PatchSet: 2
Gerrit-Owner: Nathanael Premillieu <[email protected]>
Gerrit-Reviewer: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nathanael Premillieu <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
