Actually, I misspoke. The small files are the .py files in
arch/x86/isa/insts/** which have a single variable declared holding
microcode. The .isa files process them and do a few other things and
tend to be longer.
Gabe
Gabe Black wrote:
A few (a vast minority) of .isa files for x86 should have UM
copyright on them. There are a couple which are copied basically from
Alpha/SPARC which should be fairly obvious since I think they have
other people in the authors. There are a few which I did a little with
while working over the semester which could also have UM added.
There's also a temporal issue where UM copyrights might not be
applicable on changsets before a certain date, but to be technically
correct should be applied afterwards. I think the cost of being super
exact is more trouble than it's worth and over copyrighting stuff
might be the way to go. Another thing I'm thinking is that a lot of
those .isa files are fairly short, and having two copyrights on them
could make them an order of magnitude (or more) longer than they would
be otherwise. There's going to be a LOT of extra text there that might
go better in a generic license file for all that code than in every
single file. I'll leave that up to you guys. Also, I haven't at any
point in the entire time I've been working with M5 done anything with
the copyrights, including the dates, other than change the authors
line. The dates on files I did are worked on are probably totally
nonsense. Aren't copyrights good for like a thousand years anyway?
Also, please ignore anything in here you guys have already addressed.
Checking email is annoyingly slow so I'm reading these one at a time.
Gabe
nathan binkert wrote:
Found a couple of bugs this morning. New version uploaded. We're
getting to the point where everything is correct, and the main
questions I have are:
1) Should the UM copyright even be on the x86 .isa files? Seems like
the instruction definitions at least shouldn't have any UM. Gabe?
2) Should any of the MIPS files have the UM copyright on them? Ali,
Korey? Can you look at those?
3) Are there any files that should be removed from the repo? right
now, I've removed: 'util/setup-web99', 'util/setup-spec',
'util/setup-specweb', 'util/greprevs', 'util/chgcopyright')
4) Are there any other copyrights or dates that should be fixed?
5) Anything else need to be done?
Nate
On Sat, May 31, 2008 at 10:53 PM, nathan binkert <[EMAIL PROTECTED]>
wrote:
I've uploaded a new version with fixes for Ali and a few other things.
I know of no bugs in this revision. Please find some.
Nate
On Sat, May 31, 2008 at 10:14 PM, Steve Reinhardt <[EMAIL PROTECTED]>
wrote:
I don't know if they should be updated or not... I didn't mean to
imply that they should be, just that if you were updating them you
weren't getting it right.
Steve
On Sat, May 31, 2008 at 10:04 PM, nathan binkert <[EMAIL PROTECTED]>
wrote:
The dates weren't computed. They were taken from the original files.
I only updated the copyright text, not the dates. I could compute
them, but it seems that little tiny changes shouldn't cause a
copyright change and it would be somewhat challenging to figure out
which changes were big and which were small. Do you think they
should
be computed?
I think that particular SConscript copyright for example was just
copied by me when I started working on that code, and it just took a
long ass time for me to commit it.
Nate
How are the copyright dates being computed? I'm looking through
src/mem/cache, and they don't seem right at all... most of them have
dates that end in 2005, and the SConscript has a date of 2006 even
though hg shows that it was created in 2007 and modified in 2008.
Steve
On Fri, May 30, 2008 at 10:39 PM, nathan binkert
<[EMAIL PROTECTED]> wrote:
Alright, after a bunch of tinkering, I think I've got a working
repository ready for export. It can be found at
m5sim.org:/repo/new
Please, please test things out. Look at copyrights, check out old
revisions, look at more copyrights, please make sure I didn't mess
anything up. I really need the help here. I don't want to release
the repo and find out that I've screwed it all up.
I haven't done any test compiles in a while, so that sort of thing
would help too.
Nate
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
