We'll check this in on Friday unless someone asks us to wait. Get your shots in now while there's still time!
Gabe Gabe Black wrote: > Hi everybody. This is definitely a gigantic change, but one of the nice > aspects of reviewboard seems to be that you can review whatever sized > portion of the code you like, can come back later, and that everybody's > comments accumulate. In retrospect it probably would have been easier to > work through packaged in smaller doses, but if you want to just pick off > small chunks yourself go for it. > > Gabe > > Ali Saidi wrote: > >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.m5sim.org/r/20/ >> ----------------------------------------------------------- >> >> Review request for Default. >> >> >> Summary >> ------- >> >> Initial set of patches to improve the M5 support of the ARM ISA. Bundled >> into one large change for review. This change implements the majority of >> thumb, thumb2, and arm instructions and allows the running of all tested >> SPEC2000 benchmarks in atomic mode. >> >> >> Diffs >> ----- >> >> configs/common/cpu2000.py ad784e759a74 >> src/arch/arm/ArmTLB.py ad784e759a74 >> src/arch/arm/SConscript ad784e759a74 >> src/arch/arm/faults.hh ad784e759a74 >> src/arch/arm/faults.cc ad784e759a74 >> src/arch/arm/insts/branch.hh ad784e759a74 >> src/arch/arm/insts/branch.cc ad784e759a74 >> src/arch/arm/insts/macromem.hh ad784e759a74 >> src/arch/arm/insts/macromem.cc PRE-CREATION >> src/arch/arm/insts/mem.hh ad784e759a74 >> src/arch/arm/insts/mem.cc ad784e759a74 >> src/arch/arm/insts/misc.hh PRE-CREATION >> src/arch/arm/insts/misc.cc PRE-CREATION >> src/arch/arm/insts/mult.hh PRE-CREATION >> src/arch/arm/insts/pred_inst.hh ad784e759a74 >> src/arch/arm/insts/pred_inst.cc ad784e759a74 >> src/arch/arm/insts/static_inst.hh ad784e759a74 >> src/arch/arm/insts/static_inst.cc ad784e759a74 >> src/arch/arm/insts/vfp.hh PRE-CREATION >> src/arch/arm/insts/vfp.cc PRE-CREATION >> src/arch/arm/interrupts.hh ad784e759a74 >> src/arch/arm/interrupts.cc ad784e759a74 >> src/arch/arm/intregs.hh ad784e759a74 >> src/arch/arm/isa.hh ad784e759a74 >> src/arch/arm/isa.cc PRE-CREATION >> src/arch/arm/isa/bitfields.isa ad784e759a74 >> src/arch/arm/isa/copyright.txt ad784e759a74 >> src/arch/arm/isa/decoder.isa ad784e759a74 >> src/arch/arm/isa/decoder/arm.isa PRE-CREATION >> src/arch/arm/isa/decoder/decoder.isa PRE-CREATION >> src/arch/arm/isa/decoder/thumb.isa PRE-CREATION >> src/arch/arm/isa/formats/basic.isa ad784e759a74 >> src/arch/arm/isa/formats/branch.isa ad784e759a74 >> src/arch/arm/isa/formats/breakpoint.isa PRE-CREATION >> src/arch/arm/isa/formats/data.isa PRE-CREATION >> src/arch/arm/isa/formats/formats.isa ad784e759a74 >> src/arch/arm/isa/formats/fp.isa ad784e759a74 >> src/arch/arm/isa/formats/macromem.isa ad784e759a74 >> src/arch/arm/isa/formats/mem.isa ad784e759a74 >> src/arch/arm/isa/formats/misc.isa PRE-CREATION >> src/arch/arm/isa/formats/mult.isa PRE-CREATION >> src/arch/arm/isa/formats/pred.isa ad784e759a74 >> src/arch/arm/isa/formats/uncond.isa PRE-CREATION >> src/arch/arm/isa/formats/unimp.isa ad784e759a74 >> src/arch/arm/isa/formats/unknown.isa ad784e759a74 >> src/arch/arm/isa/formats/util.isa ad784e759a74 >> src/arch/arm/isa/includes.isa ad784e759a74 >> src/arch/arm/isa/insts/basic.isa PRE-CREATION >> src/arch/arm/isa/insts/branch.isa PRE-CREATION >> src/arch/arm/isa/insts/data.isa PRE-CREATION >> src/arch/arm/isa/insts/div.isa PRE-CREATION >> src/arch/arm/isa/insts/fp.isa PRE-CREATION >> src/arch/arm/isa/insts/insts.isa PRE-CREATION >> src/arch/arm/isa/insts/ldr.isa PRE-CREATION >> src/arch/arm/isa/insts/macromem.isa PRE-CREATION >> src/arch/arm/isa/insts/mem.isa PRE-CREATION >> src/arch/arm/isa/insts/misc.isa PRE-CREATION >> src/arch/arm/isa/insts/mult.isa PRE-CREATION >> src/arch/arm/isa/insts/str.isa PRE-CREATION >> src/arch/arm/isa/insts/swap.isa PRE-CREATION >> src/arch/arm/isa/main.isa ad784e759a74 >> src/arch/arm/isa/operands.isa ad784e759a74 >> src/arch/arm/isa/templates/basic.isa PRE-CREATION >> src/arch/arm/isa/templates/branch.isa PRE-CREATION >> src/arch/arm/isa/templates/macromem.isa PRE-CREATION >> src/arch/arm/isa/templates/mem.isa PRE-CREATION >> src/arch/arm/isa/templates/misc.isa PRE-CREATION >> src/arch/arm/isa/templates/mult.isa PRE-CREATION >> src/arch/arm/isa/templates/pred.isa PRE-CREATION >> src/arch/arm/isa/templates/templates.isa PRE-CREATION >> src/arch/arm/isa/templates/vfp.isa PRE-CREATION >> src/arch/arm/isa_traits.hh ad784e759a74 >> src/arch/arm/linux/linux.hh ad784e759a74 >> src/arch/arm/linux/process.hh ad784e759a74 >> src/arch/arm/linux/process.cc ad784e759a74 >> src/arch/arm/miscregs.hh ad784e759a74 >> src/arch/arm/miscregs.cc PRE-CREATION >> src/arch/arm/nativetrace.cc ad784e759a74 >> src/arch/arm/pagetable.hh ad784e759a74 >> src/arch/arm/pagetable.cc ad784e759a74 >> src/arch/arm/predecoder.hh ad784e759a74 >> src/arch/arm/process.hh ad784e759a74 >> src/arch/arm/process.cc ad784e759a74 >> src/arch/arm/registers.hh ad784e759a74 >> src/arch/arm/table_walker.hh PRE-CREATION >> src/arch/arm/table_walker.cc PRE-CREATION >> src/arch/arm/tlb.hh ad784e759a74 >> src/arch/arm/tlb.cc ad784e759a74 >> src/arch/arm/types.hh ad784e759a74 >> src/arch/arm/utility.hh ad784e759a74 >> src/arch/arm/utility.cc ad784e759a74 >> src/arch/isa_parser.py ad784e759a74 >> src/base/loader/elf_object.cc ad784e759a74 >> src/base/loader/object_file.hh ad784e759a74 >> src/cpu/BaseCPU.py ad784e759a74 >> src/cpu/exetrace.cc ad784e759a74 >> src/cpu/simple/base.cc ad784e759a74 >> src/cpu/simple_thread.hh ad784e759a74 >> src/dev/arm/SConscript ad784e759a74 >> src/dev/arm/Versatile.py ad784e759a74 >> src/dev/arm/versatile.hh ad784e759a74 >> src/dev/arm/versatile.cc ad784e759a74 >> src/dev/copy_engine.cc ad784e759a74 >> src/dev/io_device.hh ad784e759a74 >> src/dev/io_device.cc ad784e759a74 >> src/sim/process.cc ad784e759a74 >> tests/quick/00.hello/ref/arm/linux/simple-atomic/config.ini ad784e759a74 >> tests/quick/00.hello/ref/arm/linux/simple-atomic/simerr ad784e759a74 >> tests/quick/00.hello/ref/arm/linux/simple-atomic/simout ad784e759a74 >> tests/quick/00.hello/ref/arm/linux/simple-atomic/stats.txt ad784e759a74 >> util/statetrace/arch/tracechild_arm.hh ad784e759a74 >> util/statetrace/arch/tracechild_arm.cc ad784e759a74 >> util/statetrace/statetrace.cc ad784e759a74 >> >> Diff: http://reviews.m5sim.org/r/20/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Ali >> >> _______________________________________________ >> m5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/listinfo/m5-dev >> >> > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
