Sorry about that.  I thought I was compiling with mysql.  I'll fix
that right now.

  Nate

On Tue, Jun 15, 2010 at 10:30 AM, Ali Saidi <[email protected]> wrote:
>
> Your change broke compilation of all ISAs:
>
> build/ALPHA_FS/base/stats/mysql.cc: In member function 'bool
> Stats::MySql::configure(const Stats::Info&, std::string)':
> build/ALPHA_FS/base/stats/mysql.cc:433: error: 'print' was not declared in
> this scope
> build/ALPHA_FS/base/stats/mysql.cc: In member function 'void
> Stats::MySql::output(const Stats::ScalarInfo&)':
> build/ALPHA_FS/base/stats/mysql.cc:632: error: 'print' was not declared in
> this scope
> build/ALPHA_FS/base/stats/mysql.cc: In member function 'void
> Stats::MySql::output(const Stats::VectorInfo&)':
> build/ALPHA_FS/base/stats/mysql.cc:646: error: 'print' was not declared in
> this scope
> build/ALPHA_FS/base/stats/mysql.cc: In member function 'void
> Stats::MySql::output(const Stats::DistInfo&)':
> build/ALPHA_FS/base/stats/mysql.cc:713: error: 'print' was not declared in
> this scope
> build/ALPHA_FS/base/stats/mysql.cc: In member function 'void
> Stats::MySql::output(const Stats::VectorDistInfo&)':
> build/ALPHA_FS/base/stats/mysql.cc:724: error: 'print' was not declared in
> this scope
> build/ALPHA_FS/base/stats/mysql.cc: In member function 'void
> Stats::MySql::output(const Stats::Vector2dInfo&)':
> build/ALPHA_FS/base/stats/mysql.cc:740: error: 'print' was not declared in
> this scope
>
> Ali
>
>
> On Tue, 15 Jun 2010 12:15:21 -0400, Nathan Binkert wrote:
>> changeset 0c61c3cf7639 in /z/repo/m5
>> details: http://repo.m5sim.org/m5?cmd=changeset;node=0c61c3cf7639
>> description:
>>       stats: rename print to display so it work in python
>>
>> diffstat:
>>
>>  src/base/statistics.cc |  4 ++--
>>  src/base/statistics.hh |  2 +-
>>  src/base/stats/info.hh |  4 ++--
>>  src/base/stats/text.cc |  2 +-
>>  4 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diffs (66 lines):
>>
>> diff -r 5a07045d0af2 -r 0c61c3cf7639 src/base/statistics.cc
>> --- a/src/base/statistics.cc  Tue Jun 15 01:18:36 2010 -0700
>> +++ b/src/base/statistics.cc  Tue Jun 15 08:34:19 2010 -0700
>> @@ -192,7 +192,7 @@
>>          return false;
>>      }
>>
>> -    if ((flags & print) && name.empty()) {
>> +    if ((flags & display) && name.empty()) {
>>          panic("all printable stats must be named");
>>          return false;
>>      }
>> @@ -331,7 +331,7 @@
>>      off_t j = 0;
>>      for (i = statsList().begin(); i != end; ++i) {
>>          Info *info = *i;
>> -        if (!(info->flags & print))
>> +        if (!(info->flags & display))
>>              info->name = "__Stat" + to_string(j++);
>>      }
>>
>> diff -r 5a07045d0af2 -r 0c61c3cf7639 src/base/statistics.hh
>> --- a/src/base/statistics.hh  Tue Jun 15 01:18:36 2010 -0700
>> +++ b/src/base/statistics.hh  Tue Jun 15 08:34:19 2010 -0700
>> @@ -245,7 +245,7 @@
>>      {
>>          Info *info = this->info();
>>          info->setName(name);
>> -        info->flags.set(print);
>> +        info->flags.set(display);
>>          return this->self();
>>      }
>>      const std::string &name() const { return this->info()->name; }
>> diff -r 5a07045d0af2 -r 0c61c3cf7639 src/base/stats/info.hh
>> --- a/src/base/stats/info.hh  Tue Jun 15 01:18:36 2010 -0700
>> +++ b/src/base/stats/info.hh  Tue Jun 15 08:34:19 2010 -0700
>> @@ -44,7 +44,7 @@
>>  /** This Stat is Initialized */
>>  const FlagsType init =          0x0001;
>>  /** Print this stat. */
>> -const FlagsType print =         0x0002;
>> +const FlagsType display =       0x0002;
>>  /** Print the total. */
>>  const FlagsType total =         0x0010;
>>  /** Print the percent of the total that this entry represents. */
>> @@ -59,7 +59,7 @@
>>  const FlagsType nonan =         0x0200;
>>
>>  /** Mask of flags that can't be set directly */
>> -const FlagsType __reserved =    init | print;
>> +const FlagsType __reserved =    init | display;
>>
>>  struct StorageParams
>>  {
>> diff -r 5a07045d0af2 -r 0c61c3cf7639 src/base/stats/text.cc
>> --- a/src/base/stats/text.cc  Tue Jun 15 01:18:36 2010 -0700
>> +++ b/src/base/stats/text.cc  Tue Jun 15 08:34:19 2010 -0700
>> @@ -151,7 +151,7 @@
>>  bool
>>  Text::noOutput(const Info &info)
>>  {
>> -    if (!info.flags.isSet(print))
>> +    if (!info.flags.isSet(display))
>>          return true;
>>
>>      if (info.prereq && info.prereq->zero())
>> _______________________________________________
>> m5-dev mailing list
>> [email protected]
>> http://m5sim.org/mailman/listinfo/m5-dev
>
>
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to