----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/35/#review63 -----------------------------------------------------------
It looks like this is identical to the Alpha version of this code, and is probably the right piece of code to replace the "panic unimplemented" version in every other ISA except SPARC. I'm guessing this is a can of worms that Timothy did not intend to open, but it seems like we should have a mechanism for having some common implementations of utility functions like this that can get overridden as necessary... say some sort of ISAUtility class with virtual functions. I have not kept up with the details of the evolution of the ISA code (maybe Gabe is the only one who really knows all the ins and outs anymore?). I'm also partly prompted by recent experience with overly zealous code replication in other areas... there used to be a default argsInit() method in LiveProcess that had a pretty generic stack setup, but then as minor tweaks were needed for different ISAs, we ended up with each ISA having its own copy, with about 90%+ similarity across the versions, and no one was calling the default version anymore. It would be nice if people would find ways to add hooks to common pieces of code to do just the specialization they need rather than copy-and-pasting large functions just so they can change a couple of lines. (That was a general rant, not directed at you, Timothy.) - Steve On 2010-07-09 17:53:55, Timothy Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/35/ > ----------------------------------------------------------- > > (Updated 2010-07-09 17:53:55) > > > Review request for Default. > > > Summary > ------- > > Power: Provide a utility function to copy registers from one thread context > to another in the Power ISA. > > > Diffs > ----- > > src/arch/power/SConscript 249f174e6f37 > src/arch/power/utility.hh 249f174e6f37 > src/arch/power/utility.cc PRE-CREATION > > Diff: http://reviews.m5sim.org/r/35/diff > > > Testing > ------- > > > Thanks, > > Timothy > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
