----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/57/#review86 -----------------------------------------------------------
configs/common/Options.py <http://reviews.m5sim.org/r/57/#comment232> Why exactly do these parameter names have a colon in them? Is there a particular reason that --smarts-k doesn't work? Also, what is the k value? Is there some more descriptive name that you can give to these parameters in general? i.e. --smarts-warmup, --smarts-measure --smarts-samples, etc. configs/common/Smarts.py <http://reviews.m5sim.org/r/57/#comment233> in python 2, you're going to get integer division and the rounding will happen multiple times. If a float value is not OK, then you should probably do the math as a float and round/floor it afterwards. - Nathan On 2010-07-09 18:23:13, Timothy Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/57/ > ----------------------------------------------------------- > > (Updated 2010-07-09 18:23:13) > > > Review request for Default. > > > Summary > ------- > > Sim: Add functionality to the simulation scripts to allow running with > SMARTS sampling methodology. At the moment the scripts don't support the > full range of options (e.g. you can't start from a checkpoint), and nor do > they check for incompatibility with other options. However, they do give > an example of how sampling could work with M5. > > With a benchmark that has 10 billion dynamic instructions, try: > > <m5bin> configs/example/se.py -d --caches --smarts:n 10000 --smarts:b 10 > > > Diffs > ----- > > configs/common/Options.py 249f174e6f37 > configs/common/Simulation.py 249f174e6f37 > configs/common/Smarts.py PRE-CREATION > > Diff: http://reviews.m5sim.org/r/57/diff > > > Testing > ------- > > > Thanks, > > Timothy > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
