That seems reasonable, but I still don't think being deterministic is
a good distinguishing characteristic. M5 is designed to always be
deterministic and the regressions assume the same test will always get
the same answer, so -all- tests are deterministic, even if they're
determinstically random which admittedly sounds contradictory.
Assuming my interpretation of your description is correct, I think you
mean directed tests which are, I think, tests directed towards testing
something in particular. I'm not an expert on the terminology but I
think that's right.
Gabe
Quoting "Beckmann, Brad" <[email protected]>:
I think we should incorporate the ruby tester in the same directory
structure. How about we create a new directory cpu/testers and then
move the three types of testers below that: cpu/testers/memtest,
cpu/testers/rubytest, and cpu/testers/determtest
Brad
-----Original Message-----
From: Gabe Black [mailto:[email protected]] On Behalf Of Gabe Black
Sent: Sunday, August 15, 2010 2:16 PM
To: M5 Developer List
Cc: Beckmann, Brad; Nathan Binkert
Subject: Re: [m5-dev] Review Request: ruby: Resurrected Ruby's
deterministic tests
How about putting the stuff currently in memtest into memtest/random and
this new stuff in memtest/directed? I think both are technically
determinstic as implemented.
Gabe
Brad Beckmann wrote:
On 2010-08-08 20:48:58, Nathan Binkert wrote:
I think the directory name needs to have tester in it.
src/cpu/deterministic gives you no indication of what it actually
is. Beyond that, is it really necessary to have multiple
testers? Can we not fold the functionality into a single tester?
I used the name deterministic because the directory contains
multiple deterministic testers. I changed the name to
determtest...does that work for you? These deterministic testers
serve a very different purpose than the random testers. The
deterministic testers are used for verifying latency and protocol
operation for a specific transaction. They do not stress races
like the memtest or rubytest. The deterministic testers are much
simplier than the random testers. I don't think it would be easy
to merge the different testers' logic into a single tester and I'm
not sure it is worth the effort. This code is actually not new
code. It is actually fairly old GEMS code. I'm not sure why it
was moved over in the original transfer, but I've found the code to
be very valuable.
I fixed the includes, guards, and comments. Since these aren't new
files, but actually old GEMS files, I don't think it appropriate to
change the variable names in this patch. Possibly later we can
conver all the old GEMS files to the M5 variable convention.
- Brad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/101/#review148
-----------------------------------------------------------
On 2010-08-11 12:01:17, Brad Beckmann wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/101/
-----------------------------------------------------------
(Updated 2010-08-11 12:01:17)
Review request for Default.
Summary
-------
ruby: Resurrected Ruby's deterministic tests
Added the request series and invalidate deterministic tests as new
cpu models
and removed the no longer needed ruby tests
Diffs
-----
configs/example/determ_test.py PRE-CREATION
src/cpu/determtest/DetermGenerator.hh PRE-CREATION
src/cpu/determtest/DetermGenerator.cc PRE-CREATION
src/cpu/determtest/InvalidateGenerator.hh PRE-CREATION
src/cpu/determtest/InvalidateGenerator.cc PRE-CREATION
src/cpu/determtest/RubyDetermTester.hh PRE-CREATION
src/cpu/determtest/RubyDetermTester.cc PRE-CREATION
src/cpu/determtest/RubyDetermTester.py PRE-CREATION
src/cpu/determtest/SConscript PRE-CREATION
src/cpu/determtest/SeriesRequestGenerator.hh PRE-CREATION
src/cpu/determtest/SeriesRequestGenerator.cc PRE-CREATION
src/mem/protocol/RubySlicc_Exports.sm a75564db03c3
src/mem/ruby/tester/DetermGETXGenerator.hh a75564db03c3
src/mem/ruby/tester/DetermGETXGenerator.cc a75564db03c3
src/mem/ruby/tester/DetermInvGenerator.hh a75564db03c3
src/mem/ruby/tester/DetermInvGenerator.cc a75564db03c3
src/mem/ruby/tester/DetermSeriesGETSGenerator.hh a75564db03c3
src/mem/ruby/tester/DetermSeriesGETSGenerator.cc a75564db03c3
src/mem/ruby/tester/SConscript a75564db03c3
Diff: http://reviews.m5sim.org/r/101/diff
Testing
-------
Thanks,
Brad
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
