----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/88/#review170 -----------------------------------------------------------
This works, so I hate to complain, but it would be a lot more pythonic to turn topologies into a Python package (add an __init__.py file) and turn all the makeTopology() methods into __init__ methods on the respective Topology subclasses. You might even be able to change the default for the description param into Self.__class__.__name__ and then you wouldn't have to set it explicitly (though I'm not 100% sure that would work, since proxies like Self are really only designed to work with Param attributes). Anyway, I thought I'd throw this out there and see what Nate thinks... - Steve On 2010-08-11 14:39:35, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/88/ > ----------------------------------------------------------- > > (Updated 2010-08-11 14:39:35) > > > Review request for Default. > > > Summary > ------- > > config: Added the topology name to m5 & ruby output > > > Diffs > ----- > > src/mem/ruby/network/Network.py a75564db03c3 > src/mem/ruby/network/topologies/Crossbar.py a75564db03c3 > src/mem/ruby/network/topologies/Mesh.py a75564db03c3 > src/mem/ruby/network/topologies/MeshDirCorners.py a75564db03c3 > > Diff: http://reviews.m5sim.org/r/88/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
