----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/218/#review327 -----------------------------------------------------------
I'm not really qualified to review this diff, and I'd assume ship it unless someone else objects. src/arch/arm/tlb.hh <http://reviews.m5sim.org/r/218/#comment437> Not sure if it would help, but this is another place where you could use the Flags class. - Nathan On 2010-08-23 09:39:06, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/218/ > ----------------------------------------------------------- > > (Updated 2010-08-23 09:39:06) > > > Review request for Default. > > > Summary > ------- > > ARM: Implement all ARM SIMD instructions. > > > Diffs > ----- > > src/arch/arm/insts/macromem.hh 47d9409b2b7f > src/arch/arm/insts/macromem.cc 47d9409b2b7f > src/arch/arm/insts/pred_inst.hh 47d9409b2b7f > src/arch/arm/insts/static_inst.hh 47d9409b2b7f > src/arch/arm/insts/vfp.hh 47d9409b2b7f > src/arch/arm/insts/vfp.cc 47d9409b2b7f > src/arch/arm/isa/decoder/thumb.isa 47d9409b2b7f > src/arch/arm/isa/formats/fp.isa 47d9409b2b7f > src/arch/arm/isa/insts/fp.isa 47d9409b2b7f > src/arch/arm/isa/insts/insts.isa 47d9409b2b7f > src/arch/arm/isa/insts/macromem.isa 47d9409b2b7f > src/arch/arm/isa/insts/neon.isa PRE-CREATION > src/arch/arm/isa/operands.isa 47d9409b2b7f > src/arch/arm/isa/templates/macromem.isa 47d9409b2b7f > src/arch/arm/isa/templates/mem.isa 47d9409b2b7f > src/arch/arm/isa/templates/neon.isa PRE-CREATION > src/arch/arm/isa/templates/templates.isa 47d9409b2b7f > src/arch/arm/tlb.hh 47d9409b2b7f > > Diff: http://reviews.m5sim.org/r/218/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
