> On 2010-12-21 22:30:11, Steve Reinhardt wrote:
> > src/base/debug.hh, line 38
> > <http://reviews.m5sim.org/r/351/diff/1/?file=5592#file5592line38>
> >
> > It looks like we're not completely consistent on this, but I'd put the
> > close brace in column 0, then put the comment after that, e.g.:
> >
> > } // namespace Debug
> >
> > I don't care much about C vs C++-style comments, but having the brace
> > in column 0 seems much more natural since that's where it would be if we
> > weren't commenting it.
> >
> > Other than that nit (which applies several places), this looks good to
> > me.
> >
>
> Nathan Binkert wrote:
> I've been doing it this way for years :) I think the reason that I
> decided to do it this way is that we chose to *not* have namespaces change
> the indention level. I honestly don't care, but there are a ton of examples
> that look like this, so we should consciously decide on one and change them
> everywhere and document it. (Since you brought it up, do you volunteer?
> Offering code goes a hell of a long way in a coding debate :)
Ask and ye shall receive... sometimes, anyway. FYI, the '//' comments
outnumbered the '/*' comments something like 79 to 54, but there was surprising
variety in the details ('namespace Foo', 'end namespace Foo', 'Foo namespace').
But hey, stand back, I know regular expressions :-)
- Steve
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/351/#review563
-----------------------------------------------------------
On 2010-12-21 08:25:03, Nathan Binkert wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/351/
> -----------------------------------------------------------
>
> (Updated 2010-12-21 08:25:03)
>
>
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and
> Nathan Binkert.
>
>
> Summary
> -------
>
> debug: create a Debug namespace
>
>
> Diffs
> -----
>
> src/arch/alpha/ev5.cc 4a3bddd74f36
> src/base/debug.hh 4a3bddd74f36
> src/base/debug.cc 4a3bddd74f36
> src/base/statistics.cc 4a3bddd74f36
> src/cpu/pc_event.cc 4a3bddd74f36
> src/dev/ns_gige.cc 4a3bddd74f36
> src/dev/sinic.cc 4a3bddd74f36
> src/sim/debug.cc 4a3bddd74f36
> src/sim/pseudo_inst.cc 4a3bddd74f36
>
> Diff: http://reviews.m5sim.org/r/351/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Nathan
>
>
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
