----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/352/#review625 -----------------------------------------------------------
src/base/debug.hh <http://reviews.m5sim.org/r/352/#comment838> This file needs doxygen comments. Minimally an @file comment, but preferably documenting each class as well. src/base/debug.hh <http://reviews.m5sim.org/r/352/#comment837> The things we do to not use varargs.... src/base/debug.cc <http://reviews.m5sim.org/r/352/#comment839> These comments should really be doxygen comments and there should be ones for the various functions below (e.g. findFlag) src/base/debug.cc <http://reviews.m5sim.org/r/352/#comment840> More comments please src/base/remote_gdb.cc <http://reviews.m5sim.org/r/352/#comment841> Mabye emitting the individual header files and the compound header file and the user can choose? src/base/trace.hh <http://reviews.m5sim.org/r/352/#comment842> Doxygen src/python/m5/debug.py <http://reviews.m5sim.org/r/352/#comment843> More comments please, at least what this file exists to do - Ali On 2010-12-21 08:36:19, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/352/ > ----------------------------------------------------------- > > (Updated 2010-12-21 08:36:19) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > trace: reimplement the DTRACE function so it doesn't use a vector > > One question I have about this stuff is if I should call everything trace, or > debug? This diff is somewhat confused about that (some things are trace and > some things are debug) and I expect to fix it. We always called this stuff > "trace flags" in the past, but we I would like to start using these flags for > other things. For example, turning on and off debugging breakpoints of > different kinds. Execution tracing is a totally different mechanism but does > use trace flags. My personal inclination is that trace flag is probably a > bad name, but perhaps debug is a bad name too. Just call it "flags"? Or > SimFlags? > > > Diffs > ----- > > src/SConscript 4a3bddd74f36 > src/arch/alpha/interrupts.hh 4a3bddd74f36 > src/arch/alpha/kernel_stats.cc 4a3bddd74f36 > src/arch/alpha/linux/process.cc 4a3bddd74f36 > src/arch/alpha/linux/system.cc 4a3bddd74f36 > src/arch/alpha/process.cc 4a3bddd74f36 > src/arch/alpha/remote_gdb.cc 4a3bddd74f36 > src/arch/alpha/stacktrace.hh 4a3bddd74f36 > src/arch/alpha/system.cc 4a3bddd74f36 > src/arch/alpha/tlb.cc 4a3bddd74f36 > src/arch/alpha/vtophys.cc 4a3bddd74f36 > src/arch/arm/faults.cc 4a3bddd74f36 > src/arch/arm/isa.hh 4a3bddd74f36 > src/arch/arm/isa.cc 4a3bddd74f36 > src/arch/arm/isa/includes.isa 4a3bddd74f36 > src/arch/arm/nativetrace.cc 4a3bddd74f36 > src/arch/arm/predecoder.cc 4a3bddd74f36 > src/arch/arm/process.cc 4a3bddd74f36 > src/arch/arm/remote_gdb.cc 4a3bddd74f36 > src/arch/arm/stacktrace.hh 4a3bddd74f36 > src/arch/arm/tlb.cc 4a3bddd74f36 > src/arch/mips/faults.cc 4a3bddd74f36 > src/arch/mips/isa.cc 4a3bddd74f36 > src/arch/mips/isa/includes.isa 4a3bddd74f36 > src/arch/mips/linux/process.cc 4a3bddd74f36 > src/arch/mips/locked_mem.hh 4a3bddd74f36 > src/arch/mips/process.cc 4a3bddd74f36 > src/arch/mips/stacktrace.hh 4a3bddd74f36 > src/arch/mips/tlb.cc 4a3bddd74f36 > src/arch/power/process.cc 4a3bddd74f36 > src/arch/power/stacktrace.hh 4a3bddd74f36 > src/arch/power/tlb.cc 4a3bddd74f36 > src/arch/sparc/interrupts.hh 4a3bddd74f36 > src/arch/sparc/isa.cc 4a3bddd74f36 > src/arch/sparc/isa/includes.isa 4a3bddd74f36 > src/arch/sparc/process.cc 4a3bddd74f36 > src/arch/sparc/remote_gdb.cc 4a3bddd74f36 > src/arch/sparc/stacktrace.hh 4a3bddd74f36 > src/arch/sparc/tlb.cc 4a3bddd74f36 > src/arch/sparc/ua2005.cc 4a3bddd74f36 > src/arch/sparc/vtophys.cc 4a3bddd74f36 > src/arch/x86/faults.cc 4a3bddd74f36 > src/arch/x86/insts/microregop.cc 4a3bddd74f36 > src/arch/x86/insts/static_inst.hh 4a3bddd74f36 > src/arch/x86/interrupts.cc 4a3bddd74f36 > src/arch/x86/isa/includes.isa 4a3bddd74f36 > src/arch/x86/nativetrace.cc 4a3bddd74f36 > src/arch/x86/pagetable_walker.cc 4a3bddd74f36 > src/arch/x86/predecoder.hh 4a3bddd74f36 > src/arch/x86/predecoder.cc 4a3bddd74f36 > src/arch/x86/process.cc 4a3bddd74f36 > src/arch/x86/stacktrace.hh 4a3bddd74f36 > src/arch/x86/tlb.cc 4a3bddd74f36 > src/base/debug.hh 4a3bddd74f36 > src/base/debug.cc 4a3bddd74f36 > src/base/loader/aout_object.cc 4a3bddd74f36 > src/base/loader/ecoff_object.cc 4a3bddd74f36 > src/base/loader/elf_object.cc 4a3bddd74f36 > src/base/loader/raw_object.cc 4a3bddd74f36 > src/base/mysql.cc 4a3bddd74f36 > src/base/remote_gdb.cc 4a3bddd74f36 > src/base/trace.hh 4a3bddd74f36 > src/base/trace.cc 4a3bddd74f36 > src/cpu/activity.cc 4a3bddd74f36 > src/cpu/base.cc 4a3bddd74f36 > src/cpu/base_dyn_inst_impl.hh 4a3bddd74f36 > src/cpu/exetrace.hh 4a3bddd74f36 > src/cpu/exetrace.cc 4a3bddd74f36 > src/cpu/inorder/cpu.cc 4a3bddd74f36 > src/cpu/inorder/first_stage.cc 4a3bddd74f36 > src/cpu/inorder/inorder_dyn_inst.cc 4a3bddd74f36 > src/cpu/inorder/inorder_trace.cc 4a3bddd74f36 > src/cpu/inorder/pipeline_stage.cc 4a3bddd74f36 > src/cpu/inorder/reg_dep_map.cc 4a3bddd74f36 > src/cpu/inorder/resource.cc 4a3bddd74f36 > src/cpu/inorder/resource_pool.cc 4a3bddd74f36 > src/cpu/inorder/resources/agen_unit.cc 4a3bddd74f36 > src/cpu/inorder/resources/bpred_unit.cc 4a3bddd74f36 > src/cpu/inorder/resources/branch_predictor.cc 4a3bddd74f36 > src/cpu/inorder/resources/cache_unit.cc 4a3bddd74f36 > src/cpu/inorder/resources/decode_unit.cc 4a3bddd74f36 > src/cpu/inorder/resources/execution_unit.cc 4a3bddd74f36 > src/cpu/inorder/resources/fetch_seq_unit.cc 4a3bddd74f36 > src/cpu/inorder/resources/graduation_unit.cc 4a3bddd74f36 > src/cpu/inorder/resources/inst_buffer.cc 4a3bddd74f36 > src/cpu/inorder/resources/mult_div_unit.cc 4a3bddd74f36 > src/cpu/inorder/resources/use_def.cc 4a3bddd74f36 > src/cpu/inorder/thread_context.cc 4a3bddd74f36 > src/cpu/inteltrace.hh 4a3bddd74f36 > src/cpu/intr_control.cc 4a3bddd74f36 > src/cpu/nativetrace.cc 4a3bddd74f36 > src/cpu/o3/bpred_unit_impl.hh 4a3bddd74f36 > src/cpu/o3/commit_impl.hh 4a3bddd74f36 > src/cpu/o3/cpu.cc 4a3bddd74f36 > src/cpu/o3/decode_impl.hh 4a3bddd74f36 > src/cpu/o3/fetch_impl.hh 4a3bddd74f36 > src/cpu/o3/free_list.hh 4a3bddd74f36 > src/cpu/o3/free_list.cc 4a3bddd74f36 > src/cpu/o3/iew.hh 4a3bddd74f36 > src/cpu/o3/iew_impl.hh 4a3bddd74f36 > src/cpu/o3/inst_queue_impl.hh 4a3bddd74f36 > src/cpu/o3/lsq_impl.hh 4a3bddd74f36 > src/cpu/o3/lsq_unit.hh 4a3bddd74f36 > src/cpu/o3/lsq_unit_impl.hh 4a3bddd74f36 > src/cpu/o3/mem_dep_unit.hh 4a3bddd74f36 > src/cpu/o3/mem_dep_unit_impl.hh 4a3bddd74f36 > src/cpu/o3/regfile.hh 4a3bddd74f36 > src/cpu/o3/rename_impl.hh 4a3bddd74f36 > src/cpu/o3/rename_map.cc 4a3bddd74f36 > src/cpu/o3/rob_impl.hh 4a3bddd74f36 > src/cpu/o3/scoreboard.hh 4a3bddd74f36 > src/cpu/o3/scoreboard.cc 4a3bddd74f36 > src/cpu/o3/store_set.cc 4a3bddd74f36 > src/cpu/o3/thread_context_impl.hh 4a3bddd74f36 > src/cpu/pc_event.cc 4a3bddd74f36 > src/cpu/pred/2bit_local.cc 4a3bddd74f36 > src/cpu/pred/btb.cc 4a3bddd74f36 > src/cpu/quiesce_event.cc 4a3bddd74f36 > src/cpu/simple/atomic.cc 4a3bddd74f36 > src/cpu/simple/base.cc 4a3bddd74f36 > src/cpu/simple/timing.cc 4a3bddd74f36 > src/cpu/simple_thread.hh 4a3bddd74f36 > src/cpu/testers/memtest/memtest.cc 4a3bddd74f36 > src/cpu/thread_context.cc 4a3bddd74f36 > src/dev/alpha/backdoor.cc 4a3bddd74f36 > src/dev/alpha/tsunami_cchip.cc 4a3bddd74f36 > src/dev/alpha/tsunami_io.cc 4a3bddd74f36 > src/dev/alpha/tsunami_pchip.cc 4a3bddd74f36 > src/dev/copy_engine.cc 4a3bddd74f36 > src/dev/disk_image.cc 4a3bddd74f36 > src/dev/etherbus.cc 4a3bddd74f36 > src/dev/etherlink.cc 4a3bddd74f36 > src/dev/ethertap.cc 4a3bddd74f36 > src/dev/i8254xGBe.hh 4a3bddd74f36 > src/dev/i8254xGBe.cc 4a3bddd74f36 > src/dev/ide_ctrl.cc 4a3bddd74f36 > src/dev/ide_disk.cc 4a3bddd74f36 > src/dev/intel_8254_timer.hh 4a3bddd74f36 > src/dev/intel_8254_timer.cc 4a3bddd74f36 > src/dev/io_device.cc 4a3bddd74f36 > src/dev/isa_fake.cc 4a3bddd74f36 > src/dev/mc146818.cc 4a3bddd74f36 > src/dev/ns_gige.cc 4a3bddd74f36 > src/dev/pciconfigall.cc 4a3bddd74f36 > src/dev/pcidev.cc 4a3bddd74f36 > src/dev/simple_disk.cc 4a3bddd74f36 > src/dev/sinic.cc 4a3bddd74f36 > src/dev/sparc/iob.cc 4a3bddd74f36 > src/dev/sparc/mm_disk.cc 4a3bddd74f36 > src/dev/terminal.cc 4a3bddd74f36 > src/dev/uart8250.cc 4a3bddd74f36 > src/dev/x86/cmos.cc 4a3bddd74f36 > src/dev/x86/i8042.cc 4a3bddd74f36 > src/dev/x86/i82094aa.cc 4a3bddd74f36 > src/dev/x86/i8254.cc 4a3bddd74f36 > src/dev/x86/i8259.cc 4a3bddd74f36 > src/dev/x86/speaker.cc 4a3bddd74f36 > src/kern/linux/events.cc 4a3bddd74f36 > src/kern/linux/linux.cc 4a3bddd74f36 > src/kern/system_events.cc 4a3bddd74f36 > src/kern/tru64/tru64.hh 4a3bddd74f36 > src/kern/tru64/tru64_events.cc 4a3bddd74f36 > src/mem/bridge.cc 4a3bddd74f36 > src/mem/bus.cc 4a3bddd74f36 > src/mem/cache/base.hh 4a3bddd74f36 > src/mem/cache/base.cc 4a3bddd74f36 > src/mem/cache/cache_impl.hh 4a3bddd74f36 > src/mem/cache/mshr.cc 4a3bddd74f36 > src/mem/cache/prefetch/base.cc 4a3bddd74f36 > src/mem/cache/prefetch/ghb.cc 4a3bddd74f36 > src/mem/cache/prefetch/stride.cc 4a3bddd74f36 > src/mem/cache/tags/iic.cc 4a3bddd74f36 > src/mem/cache/tags/lru.cc 4a3bddd74f36 > src/mem/page_table.cc 4a3bddd74f36 > src/mem/physical.cc 4a3bddd74f36 > src/mem/port.cc 4a3bddd74f36 > src/mem/ruby/common/Debug.hh 4a3bddd74f36 > src/mem/ruby/common/Debug.cc 4a3bddd74f36 > src/mem/ruby/common/Debug.py 4a3bddd74f36 > src/mem/ruby/common/Global.hh 4a3bddd74f36 > src/mem/ruby/common/Global.cc 4a3bddd74f36 > src/mem/ruby/system/Sequencer.cc 4a3bddd74f36 > src/mem/slicc/symbols/StateMachine.py 4a3bddd74f36 > src/mem/tport.cc 4a3bddd74f36 > src/python/m5/debug.py 4a3bddd74f36 > src/python/m5/main.py 4a3bddd74f36 > src/python/m5/trace.py 4a3bddd74f36 > src/python/swig/debug.i 4a3bddd74f36 > src/python/swig/trace.i 4a3bddd74f36 > src/sim/eventq.hh 4a3bddd74f36 > src/sim/eventq.cc 4a3bddd74f36 > src/sim/faults.cc 4a3bddd74f36 > src/sim/pseudo_inst.cc 4a3bddd74f36 > src/sim/sim_object.cc 4a3bddd74f36 > src/sim/syscall_emul.hh 4a3bddd74f36 > src/sim/syscall_emul.cc 4a3bddd74f36 > src/sim/system.cc 4a3bddd74f36 > > Diff: http://reviews.m5sim.org/r/352/diff > > > Testing > ------- > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
