----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/382/#review639 -----------------------------------------------------------
I think there are two problems with this patch. First, if at all possible we should avoid the code duplication we'd now have for the recvTiming function. Second, while this probably does fix the legitimate problem of deleting packets twice, I think it creates a memory leak in the process. I suspect if you leave your other changes in place but get rid of your custom recvTiming function, things will still work. The packet won't be deleted by the device, won't be deleted after being received as a request in either atomic or timing mode, but will be deleted in both modes after being received as a response. The "virtual" you added in tport.hh could almost certainly go away then too. src/mem/mport.cc <http://reviews.m5sim.org/r/382/#comment862> I really don't like how much code duplication there is now between these two classes. src/mem/tport.hh <http://reviews.m5sim.org/r/382/#comment861> Marking this as explicitly virtual shouldn't really be necessary. Is there a reason you want to? - Gabe On 2011-01-06 15:56:19, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/382/ > ----------------------------------------------------------- > > (Updated 2011-01-06 15:56:19) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > MessagePort: implemented virtual recvTiming avoiding double delete > > Double packet delete problem is due to an interrupt device deleting a packet > that the SimpleTimingPort also deletes. Since MessagePort descends from > SimpleTimingPort, simply reimplement the failing code from SimpleTimingPort: > recvTiming. > > > Diffs > ----- > > src/arch/x86/interrupts.cc 9f9e10967912 > src/dev/x86/intdev.hh 9f9e10967912 > src/mem/mport.hh 9f9e10967912 > src/mem/mport.cc 9f9e10967912 > src/mem/tport.hh 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/382/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
