----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/386/#review643 -----------------------------------------------------------
I don't know all the ins and outs of checkpointing, but it looks ok to me. You aren't serializing all the state in the Interrupts object, but the things you left out I think are set up from configuration parameters directly or indirectly. Someone else will have to say whether that's ok, but I suspect it is. - Gabe On 2011-01-06 15:59:44, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/386/ > ----------------------------------------------------------- > > (Updated 2011-01-06 15:59:44) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > x86: Add checkpointing capability to arch components > > Add checkpointing capability to the x86 interrupt device and the TLBs > > > Diffs > ----- > > src/arch/x86/interrupts.hh 9f9e10967912 > src/arch/x86/interrupts.cc 9f9e10967912 > src/arch/x86/pagetable.cc 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/386/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
