----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/412/#review646 -----------------------------------------------------------
configs/common/FSConfig.py <http://reviews.m5sim.org/r/412/#comment873> How is this different from the generic makeX86System (or similarly named) function this was copied from? Duplicated code, especially so much of it, is bad news. If somebody needed to tweak the MP tables, and forgot to update both places, they'd get different behavior depending on if they had Ruby turned on. The only ruby-esque line I see is the like about dma_devices, and that's commented out. As a side issue that should be deleted, not commented out. configs/common/FSConfig.py <http://reviews.m5sim.org/r/412/#comment874> I don't think everyone that will use this config will have this file, and also not everyone that uses Ruby will be using it with parsec. - Gabe On 2011-01-06 16:06:33, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/412/ > ----------------------------------------------------------- > > (Updated 2011-01-06 16:06:33) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ruby: x86 fs config support > > > Diffs > ----- > > configs/common/FSConfig.py 9f9e10967912 > configs/example/ruby_fs.py 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/412/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
