Oops, I mean to send this to m5-dev. Gabe
-------- Original Message -------- Subject: Re: Review Request: x86: set IsCondControl flag for the appropriate microops Date: Fri, 07 Jan 2011 12:04:38 -0800 From: Gabe Black <[email protected]> To: Brad Beckmann <[email protected]> Thank you for fixing this, but in the future please update old review requests rather than making new ones. That lets us keep track of old comments and know it was an update and not a whole new thing, and I think even compare versions. If you're using postreview, use -u to update, -e to pick the review number (in the URL) and -o just cause I think you always have to for some reason. Gabe On 01/07/11 12:03, Brad Beckmann wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/415/ > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, > and Nathan Binkert. > By Brad Beckmann. > > > Description > > x86: set IsCondControl flag for the appropriate microops > > > Diffs > > * src/arch/x86/isa/microops/regop.isa (9f9e10967912) > * src/arch/x86/isa/microops/seqop.isa (9f9e10967912) > > View Diff <http://reviews.m5sim.org/r/415/diff/> >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
