> On 2011-01-07 06:13:30, Gabe Black wrote: > > What are these new pseudo instructions and script options for? I don't > > remember these being mentioned before. You should NOT check in the > > m5.disableAllListeners() line.
This patch tracks work items for those benchmarks that have had their work items annotated. The disableAllListeners line should not have been included. Sorry about that. > On 2011-01-07 06:13:30, Gabe Black wrote: > > configs/common/Options.py, line 57 > > <http://reviews.m5sim.org/r/398/diff/1/?file=9112#file9112line57> > > > > What are these for? Their descriptions aren't very helpful. If they > > only do something for x86 it seems wrong that they're displayed for every > > ISA. The are not x86 specific at all. They can be used by any workload/ISA combination. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/398/#review652 ----------------------------------------------------------- On 2011-01-06 16:13:29, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/398/ > ----------------------------------------------------------- > > (Updated 2011-01-06 16:13:29) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > m5: added work completed monitoring support > > > Diffs > ----- > > configs/common/FSConfig.py 9f9e10967912 > configs/common/Options.py 9f9e10967912 > configs/example/fs.py 9f9e10967912 > configs/example/ruby_fs.py 9f9e10967912 > src/arch/x86/isa/decoder/two_byte_opcodes.isa 9f9e10967912 > src/cpu/base.hh 9f9e10967912 > src/cpu/base.cc 9f9e10967912 > src/sim/SConscript 9f9e10967912 > src/sim/System.py 9f9e10967912 > src/sim/pseudo_inst.hh 9f9e10967912 > src/sim/pseudo_inst.cc 9f9e10967912 > src/sim/system.hh 9f9e10967912 > src/sim/system.cc 9f9e10967912 > util/m5/m5op_x86.S 9f9e10967912 > util/m5/m5ops.h 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/398/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
