> On 2010-12-08 23:56:50, Gabe Black wrote: > > src/arch/arm/isa/formats/fp.isa, line 762 > > <http://reviews.m5sim.org/r/346/diff/1/?file=5472#file5472line762> > > > > The style of this comment looks unusual, although I don't think I can > > say it's wrong. I think the line with /* should at least be otherwise > > blank, but really // style comments would work better. Gramatically this is > > actually two sentences. I think the comment in general is probably not > > necessary since the name immValid makes it pretty clear what's going on.
cleaned up with // > On 2010-12-08 23:56:50, Gabe Black wrote: > > src/arch/arm/isa/formats/fp.isa, line 767 > > <http://reviews.m5sim.org/r/346/diff/1/?file=5472#file5472line767> > > > > Misplaced brace done > On 2010-12-08 23:56:50, Gabe Black wrote: > > src/arch/arm/isa/insts/neon.isa, line 930 > > <http://reviews.m5sim.org/r/346/diff/1/?file=5474#file5474line930> > > > > delete, don't comment out all fixed - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/346/#review526 ----------------------------------------------------------- On 2010-12-06 16:14:12, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/346/ > ----------------------------------------------------------- > > (Updated 2010-12-06 16:14:12) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > The ARM decoder should not panic when decoding undefined holes in the > Architecture, as this can abort simulations when the fetch unit runs > ahead and speculatively decodes instructions that are off the execution > path or that are generated dynamically. > > > Diffs > ----- > > src/arch/arm/insts/macromem.cc 2b5fbdcbfb5d > src/arch/arm/insts/pred_inst.hh 2b5fbdcbfb5d > src/arch/arm/isa/formats/fp.isa 2b5fbdcbfb5d > src/arch/arm/isa/formats/misc.isa 2b5fbdcbfb5d > src/arch/arm/isa/insts/neon.isa 2b5fbdcbfb5d > src/arch/arm/miscregs.cc 2b5fbdcbfb5d > > Diff: http://reviews.m5sim.org/r/346/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
