----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/380/#review700 -----------------------------------------------------------
src/sim/System.py <http://reviews.m5sim.org/r/380/#comment945> Where is this parameter actually used? For the latest version of the patch, moved it from BaseCPU to System, but it seesm like we should just remove it altogether. Am I missing something? - Brad On 2011-01-10 10:48:23, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/380/ > ----------------------------------------------------------- > > (Updated 2011-01-10 10:48:23) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > mcpat: Adds McPAT performance counters > > Updated patches from Rick Strong's set that modify performance counters for > McPAT > > > Diffs > ----- > > src/cpu/BaseCPU.py 9f9e10967912 > src/cpu/base.cc 9f9e10967912 > src/cpu/o3/commit.hh 9f9e10967912 > src/cpu/o3/commit_impl.hh 9f9e10967912 > src/cpu/o3/cpu.hh 9f9e10967912 > src/cpu/o3/cpu.cc 9f9e10967912 > src/cpu/o3/iew_impl.hh 9f9e10967912 > src/cpu/o3/inst_queue.hh 9f9e10967912 > src/cpu/o3/inst_queue_impl.hh 9f9e10967912 > src/cpu/o3/rename.hh 9f9e10967912 > src/cpu/o3/rename_impl.hh 9f9e10967912 > src/cpu/o3/rob.hh 9f9e10967912 > src/cpu/o3/rob_impl.hh 9f9e10967912 > src/cpu/simple/atomic.cc 9f9e10967912 > src/cpu/simple/base.hh 9f9e10967912 > src/cpu/simple/base.cc 9f9e10967912 > src/cpu/simple/timing.cc 9f9e10967912 > src/sim/System.py 9f9e10967912 > src/sim/system.hh 9f9e10967912 > src/sim/system.cc 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/380/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
