----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/425/#review737 -----------------------------------------------------------
src/base/time.hh <http://reviews.m5sim.org/r/425/#comment1000> heh, but the constant will have that many zeroes too! I could use 1000*1000*1000 if you prefer. I'll figure something out. src/base/time.cc <http://reviews.m5sim.org/r/425/#comment999> Oh, I used whatever you used. CLOCK_REALTIME is fine too, though I guess I never really cared about the fact that I could print the time as a string. I am generally more interested in using it for measuring how long things take. I hesitate to make this code more complex, but I guess I could create a set_wallclock() func that does one and a set_timer() that does the other. - Nathan On 2011-01-13 19:43:31, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/425/ > ----------------------------------------------------------- > > (Updated 2011-01-13 19:43:31) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > time: improve time datastructure > > Use posix clock functions (and librt) if it is available. > Inline a bunch of functions and implement more operators. > > I needed something like this for some timing code that I needed, so I just > did it right since I assume that Gabe could use this to better his patch. > > > Diffs > ----- > > SConstruct de7601e6e19d > src/base/time.hh de7601e6e19d > src/base/time.cc de7601e6e19d > src/sim/stat_control.cc de7601e6e19d > > Diff: http://reviews.m5sim.org/r/425/diff > > > Testing > ------- > > quick regressions pass > > > Thanks, > > Nathan > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
