----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/428/#review740 -----------------------------------------------------------
Looks great to me with one exception, documentation. All these functions and files need doxygen comments and although it's not required it would be great if you created a wiki page on unit tests and described the frame work. If you had the time to also have a section on adding your own tests that would be even better. - Ali On 2011-01-15 00:33:48, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/428/ > ----------------------------------------------------------- > > (Updated 2011-01-15 00:33:48) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Unit tests: Define a header file for common unit testing functions/macros. > > > Diffs > ----- > > src/unittest/SConscript a82dcad2bc18 > src/unittest/unittest.hh PRE-CREATION > src/unittest/unittest.cc PRE-CREATION > > Diff: http://reviews.m5sim.org/r/428/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
