----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/396/#review796 -----------------------------------------------------------
src/arch/x86/pagetable_walker.cc <http://reviews.m5sim.org/r/396/#comment1118> Possible memory leak? I think the sender is responsible for cleaning up the packet for atomic accesses, and I don't see where that's being done. I may be wrong about atomic mode, or have missed where this is cleaned up. src/arch/x86/pagetable_walker.cc <http://reviews.m5sim.org/r/396/#comment1116> Possible memory leak? src/arch/x86/pagetable_walker.cc <http://reviews.m5sim.org/r/396/#comment1115> Instead of putting the majority of this function in an if/else, you could split it into two different functions. Then you could make the functional part take different parameters and not have to use the req or translation object to ferry information back. src/arch/x86/pagetable_walker.cc <http://reviews.m5sim.org/r/396/#comment1117> Possible memory leak? Same rational as atomic mode. src/arch/x86/pagetable_walker.cc <http://reviews.m5sim.org/r/396/#comment1119> Possible memory leak? If write is set to something we can't just lose it, we need to clean it up. That doesn't apply if write is statically allocated, but I don't see where that's happening. - Gabe On 2011-01-20 16:57:10, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/396/ > ----------------------------------------------------------- > > (Updated 2011-01-20 16:57:10) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > x86: Timing support for pagetable walker > > Move page table walker state to its own object type, and make the > walker instantiate state for each outstanding walk. By storing the > states in a queue, the walker is able to handle multiple outstanding > timing requests. Note that functional walks use separate state > elements. > > > Diffs > ----- > > src/arch/x86/tlb.hh 9f9e10967912 > src/arch/x86/tlb.cc 9f9e10967912 > src/arch/x86/pagetable_walker.cc 9f9e10967912 > src/arch/x86/pagetable_walker.hh 9f9e10967912 > > Diff: http://reviews.m5sim.org/r/396/diff > > > Testing > ------- > > > Thanks, > > Brad > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
