----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/439/#review801 -----------------------------------------------------------
The code in storebuffer.cc looks pretty suspect. Where it was looking for something from libruby, you replaced that by a zero. Seems that the code won't work anymore in that case. If this is correct, then the code is very confusing and a little bit of cleanup would be warranted. src/mem/ruby/storebuffer/storebuffer.cc <http://reviews.m5sim.org/r/439/#comment1120> Is this right? My guess is that the entire "if (!m_use_storebuffer) { }" block should be replaced by an "if (!m_use_storebuffer) fatal("must provide a storebuffer in the configuration")" or something like this. I don't see how this could work without a storebuffer. src/mem/ruby/storebuffer/storebuffer.cc <http://reviews.m5sim.org/r/439/#comment1121> fatal() ? Isn't a storebuffer required? src/mem/ruby/storebuffer/storebuffer.cc <http://reviews.m5sim.org/r/439/#comment1122> panic? src/mem/ruby/storebuffer/storebuffer.cc <http://reviews.m5sim.org/r/439/#comment1123> panic? - Nathan On 2011-01-25 09:25:35, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/439/ > ----------------------------------------------------------- > > (Updated 2011-01-25 09:25:35) > > > Review request for Default. > > > Summary > ------- > > This patch removes libruby. It was already broken and is no longer required > as noted by Derek in another thread. There are still several files that > include libruby.hh, but I am not sure how to compile those. > > src/mem/ruby/tester/DeterministicDriver.cc > src/mem/ruby/tester/RaceyPseudoThread.hh > src/mem/ruby/tester/test_framework.cc > src/mem/ruby/tester/RaceyDriver.hh > src/mem/ruby/tester/DeterministicDriver.hh > src/mem/ruby/tester/RaceyDriver.cc > src/mem/ruby/tester/RaceyPseudoThread.cc > > > Diffs > ----- > > src/mem/ruby/libruby.cc 31a04e5ac4be > src/mem/ruby/libruby.hh 31a04e5ac4be > src/mem/ruby/SConscript 31a04e5ac4be > src/mem/ruby/profiler/Profiler.hh 31a04e5ac4be > src/mem/ruby/storebuffer/storebuffer.hh 31a04e5ac4be > src/mem/ruby/storebuffer/storebuffer.cc 31a04e5ac4be > src/mem/ruby/system/Sequencer.cc 31a04e5ac4be > > Diff: http://reviews.m5sim.org/r/439/diff > > > Testing > ------- > > > Thanks, > > Nilay > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
