> On 2011-01-18 18:12:32, Nathan Binkert wrote: > > src/base/vnc/vncserver.hh, line 150 > > <http://reviews.m5sim.org/r/432/diff/1/?file=9748#file9748line150> > > > > Brace is usually on new line for struct, but in this case, perhaps we > > don't care. > > Ali Saidi wrote: > There are so many of these i think it could go against Steve's desire for > dense code > > Nathan Binkert wrote: > Yeah, that's fine with me. As long as there is no code inside, I'm cool.
Thanks for thinking of me :-) - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/432/#review775 ----------------------------------------------------------- On 2011-01-18 14:49:34, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/432/ > ----------------------------------------------------------- > > (Updated 2011-01-18 14:49:34) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > VNC: Add vnc server to M5 and support to use it for ARM. > > > Diffs > ----- > > src/dev/arm/pl111.hh 32b6354d2ae6 > src/dev/arm/kmi.cc 32b6354d2ae6 > src/dev/arm/amba_device.hh 32b6354d2ae6 > src/dev/arm/amba_device.cc 32b6354d2ae6 > src/dev/arm/kmi.hh 32b6354d2ae6 > src/dev/arm/RealView.py 32b6354d2ae6 > src/dev/SConscript 32b6354d2ae6 > src/base/vnc/vncserver.cc PRE-CREATION > src/base/vnc/vncserver.hh PRE-CREATION > src/base/vnc/convert.cc PRE-CREATION > src/base/vnc/convert.hh PRE-CREATION > src/base/vnc/VncServer.py PRE-CREATION > src/base/vnc/SConscript PRE-CREATION > configs/common/FSConfig.py 32b6354d2ae6 > src/base/SConscript 32b6354d2ae6 > src/base/bitmap.hh PRE-CREATION > src/base/bitmap.cc PRE-CREATION > src/dev/arm/pl111.cc 32b6354d2ae6 > src/dev/arm/rv_ctrl.hh 32b6354d2ae6 > src/dev/arm/rv_ctrl.cc 32b6354d2ae6 > src/dev/ps2.hh PRE-CREATION > src/dev/ps2.cc PRE-CREATION > src/sim/serialize.hh 32b6354d2ae6 > src/sim/serialize.cc 32b6354d2ae6 > > Diff: http://reviews.m5sim.org/r/432/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
