----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/451/#review819 -----------------------------------------------------------
Ship it! My only suggestion would be to check whether you needed to wake up the CPU before calling that function, but I don't know if that's practical, any more efficient, or if it matters in the context of O3. - Gabe On 2011-01-27 18:25:46, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/451/ > ----------------------------------------------------------- > > (Updated 2011-01-27 18:25:46) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > O3: Fix pipeline restart when a table walk completes in the fetch stage. > > When a table walk is initiated by the fetch stage, the CPU can > potentially move to the idle state and never wake up. > > The fetch stage must call cpu->wakeCPU() when a translation completes > (in finishTranslation()). > > > Diffs > ----- > > src/cpu/o3/fetch_impl.hh 31a04e5ac4be > > Diff: http://reviews.m5sim.org/r/451/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
