I agree Nilay. Do you want to push that patch, or would you like me to take care of it? Ideally Tushar should do it, but since he's in Singapore it is probably best that you or I do it.
Thanks for pointing that out. Brad > -----Original Message----- > From: [email protected] [mailto:[email protected]] > On Behalf Of Nilay Vaish > Sent: Monday, February 07, 2011 9:23 AM > To: M5 Developer List > Subject: Re: [m5-dev] changeset in m5: ruby: add stdio header in SRAM.hh > > Korey, I think the printf statements should be replaced with fatal() or > panic() instead. > > -- > Nilay > > > On Mon, 7 Feb 2011, Korey Sewell wrote: > > > changeset 5f2a2deb377d in /z/repo/m5 > > details: http://repo.m5sim.org/m5?cmd=changeset;node=5f2a2deb377d > > description: > > ruby: add stdio header in SRAM.hh > > missing header file caused RUBY_FS to not compile > > > > diffstat: > > > > src/mem/ruby/network/orion/Buffer/SRAM.hh | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diffs (11 lines): > > > > diff -r 2c2dc567a450 -r 5f2a2deb377d > src/mem/ruby/network/orion/Buffer/SRAM.hh > > --- a/src/mem/ruby/network/orion/Buffer/SRAM.hh Mon Feb 07 > 01:23:16 2011 -0800 > > +++ b/src/mem/ruby/network/orion/Buffer/SRAM.hh Mon Feb 07 > 12:19:46 2011 -0500 > > @@ -39,6 +39,7 @@ > > #include "mem/ruby/network/orion/Type.hh" > > #include "mem/ruby/network/orion/OrionConfig.hh" > > #include "mem/ruby/network/orion/TechParameter.hh" > > +#include <stdio.h> > > > > class OutdrvUnit; > > class AmpUnit; > > _______________________________________________ > > m5-dev mailing list > > [email protected] > > http://m5sim.org/mailman/listinfo/m5-dev > > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
