----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/473/#review856 -----------------------------------------------------------
I'll just third the opinions here... if this was behind a port interface, then there'd be no need to change the loader code. Also, it seems like it should go in src/mem rather than src/base. - Steve On 2011-02-11 16:43:37, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/473/ > ----------------------------------------------------------- > > (Updated 2011-02-11 16:43:37) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Added simple sparese memory implementation. > > For general modeling purposes, it is useful to have a simple memory container > which allocates storage on demand, allowing for scalable host memory usage. > This patch adds sparse_mem.hh/cc to src/base to implement such a general > purpose container object. The ELF loader and ObjectFile classes were also > extended to support loading SparseMem with ELF images. > > > Diffs > ----- > > src/base/SConscript 6548721032fa > src/base/loader/elf_object.hh 6548721032fa > src/base/loader/elf_object.cc 6548721032fa > src/base/loader/object_file.hh 6548721032fa > src/base/loader/object_file.cc 6548721032fa > src/base/sparse_mem.hh PRE-CREATION > src/base/sparse_mem.cc PRE-CREATION > > Diff: http://reviews.m5sim.org/r/473/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
