-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/485/#review867
-----------------------------------------------------------


Looks like a good idea.


configs/common/Options.py
<http://reviews.m5sim.org/r/485/#comment1236>

    Did you intend to change this default value too?  If so, why?
    


- Steve


On 2011-02-13 19:13:33, Korey Sewell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/485/
> -----------------------------------------------------------
> 
> (Updated 2011-02-13 19:13:33)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> -------
> 
> configs: set default cache params
> It's confusing (especially to new users), when you are setting some standard
> parameters (as defined in Options.py) and they aren't reflected in the 
> simulations
> so we might as well link the settings in CacheConfig.py to those in Options.py
> 
> 
> Diffs
> -----
> 
>   configs/common/CacheConfig.py 68a5b8bba293 
>   configs/common/Options.py 68a5b8bba293 
> 
> Diff: http://reviews.m5sim.org/r/485/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Korey
> 
>

_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to