----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/534/ -----------------------------------------------------------
Review request for Default. Summary ------- SLICC: Remove external_type for structures In SLICC, in order to define a type a data type for which it should not generate any code, the keyword external_type is used. For those data types for which code should be generated, the keyword structure is used. This patch eliminates the use of keyword external_type for defining structures. structure key word can now have an optional attribute external, which would be used for figuring out whether or not to generate the code for this structure. Also, now structures can have functions as well data members in them. As to why I did this, I think, I would need structures to support functions and data members both, whenever I eliminate CacheMsg class from Ruby. Also, this makes the declaration of structures more homogeneous. Diffs ----- src/mem/protocol/MESI_CMP_directory-L1cache.sm 159c07f22c8e src/mem/protocol/MESI_CMP_directory-L2cache.sm 159c07f22c8e src/mem/protocol/MESI_CMP_directory-dir.sm 159c07f22c8e src/mem/protocol/MESI_CMP_directory-dma.sm 159c07f22c8e src/mem/protocol/MI_example-cache.sm 159c07f22c8e src/mem/protocol/MI_example-dir.sm 159c07f22c8e src/mem/protocol/MOESI_CMP_directory-L1cache.sm 159c07f22c8e src/mem/protocol/MOESI_CMP_directory-L2cache.sm 159c07f22c8e src/mem/protocol/MOESI_CMP_directory-dir.sm 159c07f22c8e src/mem/protocol/MOESI_CMP_directory-dma.sm 159c07f22c8e src/mem/protocol/MOESI_CMP_token-L1cache.sm 159c07f22c8e src/mem/protocol/MOESI_CMP_token-L2cache.sm 159c07f22c8e src/mem/protocol/MOESI_CMP_token-dir.sm 159c07f22c8e src/mem/protocol/MOESI_CMP_token-dma.sm 159c07f22c8e src/mem/protocol/MOESI_hammer-cache.sm 159c07f22c8e src/mem/protocol/MOESI_hammer-dir.sm 159c07f22c8e src/mem/protocol/RubySlicc_Exports.sm 159c07f22c8e src/mem/protocol/RubySlicc_Types.sm 159c07f22c8e src/mem/slicc/parser.py 159c07f22c8e Diff: http://reviews.m5sim.org/r/534/diff Testing ------- I have compiled all the protocols in debug mode. That should be enough. Thanks, Nilay _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
