Thanks!
On 03/08/2011 07:23 PM, Nilay Vaish wrote:
Somayeh, there is an update option available in postreview. I think it
is -u <request number>. You can use that to post update already
created review requests.
--
Nilay
On Wed, 9 Mar 2011, Somayeh Sardashti wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/554/
-----------------------------------------------------------
Review request for Default and Brad Beckmann.
Summary
-------
MOESI_hammer: cache flush support: Fix the deadlock issue, and clean
up the changed files
In this version, I have redesigned the cache flushing mechanism for
the case that
the line is already in exclusive state in the cache. I think this
implementation solves the
reported deadlock issue.
I have also applied Brad's comments.
Diffs
-----
src/cpu/testers/rubytest/Check.hh baf4b5f6782e
src/cpu/testers/rubytest/Check.cc baf4b5f6782e
src/mem/packet.hh baf4b5f6782e
src/mem/packet.cc baf4b5f6782e
src/mem/protocol/MOESI_hammer-cache.sm baf4b5f6782e
src/mem/protocol/MOESI_hammer-dir.sm baf4b5f6782e
src/mem/protocol/MOESI_hammer-msg.sm baf4b5f6782e
src/mem/protocol/RubySlicc_Exports.sm baf4b5f6782e
src/mem/protocol/RubySlicc_Types.sm baf4b5f6782e
src/mem/ruby/slicc_interface/RubyRequest.hh baf4b5f6782e
src/mem/ruby/slicc_interface/RubyRequest.cc baf4b5f6782e
src/mem/ruby/system/DMASequencer.cc baf4b5f6782e
src/mem/ruby/system/RubyPort.cc baf4b5f6782e
src/mem/ruby/system/Sequencer.hh baf4b5f6782e
src/mem/ruby/system/Sequencer.cc baf4b5f6782e
Diff: http://reviews.m5sim.org/r/554/diff
Testing
-------
This implementation passes 1,000,000 ruby test cases, and is under
test for 10,000,000 cases (with random_seed activated).
Thanks,
Somayeh
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
