----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/557/#review939 -----------------------------------------------------------
Ship it! looks right to me. - Nathan On 2011-03-10 11:37:11, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/557/ > ----------------------------------------------------------- > > (Updated 2011-03-10 11:37:11) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > SCons: Stop embedding the mercurial revision into the binary. > > This causes a lot of rebuilds that could have otherwise possibly been > avoided, and, more annoyingly, a lot of unnecessary rerunning of the > regressions. The benefits of having the revision in the output haven't > materialized, so this change removes it. > > > Diffs > ----- > > SConstruct 77aa0f94e7f2 > src/SConscript 77aa0f94e7f2 > src/python/m5/main.py 77aa0f94e7f2 > > Diff: http://reviews.m5sim.org/r/557/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev