> On 2011-03-18 18:17:54, Gabe Black wrote: > > configs/example/se.py, line 160 > > <http://reviews.m5sim.org/r/600/diff/1/?file=11047#file11047line160> > > > > I applaud getting rid of the duplication, but isn't it a little > > dangerous here to set up a fake TimingSimpleCPU class and to ignore the > > se.py options? Maybe you should have a warning if the options don't match > > what you're forcing? That would avoid any potential confusion. > > > > Alternatively it might make sense to factor out the common parts of > > this script into a bunch of stuff that other people can use in an se.py > > like script of their own. That would be nice in the long term, but getting > > rid of all that code is still great right now.
Yeah, that's true, though the original ruby_se.py did the same thing. I'll put in a warning if there's a mismatch. - Lisa ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/600/#review992 ----------------------------------------------------------- On 2011-03-18 16:06:49, Lisa Hsu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/600/ > ----------------------------------------------------------- > > (Updated 2011-03-18 16:06:49) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > configs: combine ruby_se.py and se.py to avoid all that code duplication > > > Diffs > ----- > > configs/example/ruby_se.py b0ecadb07742 > configs/example/se.py b0ecadb07742 > > Diff: http://reviews.m5sim.org/r/600/diff > > > Testing > ------- > > > Thanks, > > Lisa > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
