> On 2011-03-26 12:31:49, Gabe Black wrote: > > src/arch/x86/bios/E820.py, line 53 > > <http://reviews.m5sim.org/r/609/diff/1/?file=11254#file11254line53> > > > > I think at least most of these lists should be allowed to be empty > > regardless of if they're being appended to.
They're still allowed to be empty... the question is, does that make sense as a default value? Would the system work with these parameters left as the empty list? If so, I can put that back. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/609/#review1019 ----------------------------------------------------------- On 2011-03-26 12:17:28, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/609/ > ----------------------------------------------------------- > > (Updated 2011-03-26 12:17:28) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > config: revamp x86 config to avoid appending to SimObjectVectors > A significant contributor to the need for adoptOrphanParams() > is the practice of appending to SimObjectVectors which have > already been assigned as children. This practice sidesteps the > assignment operation for those appended SimObjects, which is > where parent/child relationships are typically established. > > This patch reworks the config scripts that use append() on > SimObjectVectors, which all happen to be in the x86 system > configuration. At some point in the future, I hope to make > SimObjectVectors immutable (by deriving from tuple rather than > list), at which time this patch will be necessary for correct > operation. For now, it just avoids some of the warning > messages that get printed in adoptOrphanParams(). > > > Diffs > ----- > > configs/common/FSConfig.py d8587c913ccf > src/arch/x86/bios/E820.py d8587c913ccf > src/dev/x86/SouthBridge.py d8587c913ccf > > Diff: http://reviews.m5sim.org/r/609/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
