> On 2011-03-29 09:05:00, Gabe Black wrote: > > Why do you need this functionality? Why isn't "::" sufficient? If it's > > because some other piece of software is expecting something else, I'd say > > either write a script that munges these stats into a more acceptable > > format, or adjust the other software. I'm not an expert on our stats stuff > > by any stretch, but I'd hate to see extra otherwise unnecessary > > functionality be added to deal with a point issue that only affects a few > > people. > > brad danofsky wrote: > You are correct that this may just be my problem. I have a whole lot of > scripts that expect a different character (one used in a previous version of > m5 I think). If it is objectionable that there be support for this then so > be it. > > Steve Reinhardt wrote: > These are scripts that date back to when we used a different separator > (for SimpleScalar compatibility I believe), so arguably it's just fixing > something we broke in m5 a long time ago. I discussed this with Brad, and we > decided that in the long run the ideal thing would be to leverage the > any-day-now stats-in-python functionality to have m5 spit out stats directly > in the format that these scripts currently generate, making the scripts > obsolete. But in the meantime it's a much smaller change to tweak m5 than to > edit this pile of scripts, and I don't think it's hurting anyone to put this > in there.
It is a smaller change, but it's a smaller change that impacts -everybody- (at least theoretically) and only benefits a few people. But it's not a very big change and it sounds like it's temporary anyway (or at least that's the plan) so it's probably ok. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/610/#review1025 ----------------------------------------------------------- On 2011-03-29 09:43:16, brad danofsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/610/ > ----------------------------------------------------------- > > (Updated 2011-03-29 09:43:16) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Add the user settable separator string for arrayed stats, default is standard > :: > > I updated the diff to fix Gabes issues and I learned how to spell. > > > Diffs > ----- > > src/base/statistics.hh d8587c913ccf > src/base/statistics.cc d8587c913ccf > src/base/stats/info.hh d8587c913ccf > src/base/stats/text.cc d8587c913ccf > > Diff: http://reviews.m5sim.org/r/610/diff > > > Testing > ------- > > standard full regression > > > Thanks, > > brad > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
